feat: add zero balance accounts #8378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
force-pushed
the
zero-balance-account
branch
from
c24a6c1
to
7b6e31b
Compare
mm-near
reviewed
Jan 18, 2023
mm-near
approved these changes
Jan 18, 2023
| 1, | ||
| signer0.account_id.clone(), | ||
| new_account_id.clone(), | ||
| 0, |
There was a problem hiding this comment.
consider enabling this whole test right now - and having the condition here -- if nightly -> pass 0 as balance, if not pass something else.
There was a problem hiding this comment.
I don't think this is necessary as 1) it would make the test more complex and harder to read and 2) we already test the current behavior in other runtime tests such as test_create_account_failure_no_funds and test_validate_transaction_invalid_low_balance (which were modified) to make sure that the zero balance account does not interfere with the stable version
bowenwang1996
force-pushed
the
zero-balance-account
branch
from
d2825f6
to
485143d
Compare
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jan 30, 2023
Implements near/NEPs#448. Note: this pull request does not update account creation costs. If the NEP is approved, the costs will be updated separately.
ppca
pushed a commit
to ppca/nearcore
that referenced
this pull request
Jan 30, 2023
Implements near/NEPs#448. Note: this pull request does not update account creation costs. If the NEP is approved, the costs will be updated separately.
2 tasks
near-bulldozer bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
# Feature to stabilize Zero Balance Account that enables a more smooth onboarding experience where users don't have to first acquire NEAR tokens to pay for the storage of their accounts. # Context - NEP: near/NEPs#448 - Implementation: #8378 # Testing and QA - unit tests in runtime/runtime/src/verifier.rs - integration tests in integration-tests/src/tests/client/features/zero_balance_account.rs # Checklist - [x] [Link to nightly nayduck run](https://nayduck.near.org/#/run/2869) - [x] Update CHANGELOG.md to include this protocol feature in the `Unreleased` section.
frol
pushed a commit
to near/NEPs
that referenced
this pull request
Feb 20, 2023
NEP for #415. Implementation can be found in near/nearcore#8378
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements near/NEPs#448. Note: this pull request does not update account creation costs. If the NEP is approved, the costs will be updated separately.