feat: store user keys in GCP Datastore #103
Conversation
| @@ -57,6 +54,12 @@ enum Cli { | |||
| default_value("https://api.kitwallet.app") | |||
| )] | |||
| account_lookup_url: String, | |||
| /// GCP project ID | |||
| #[arg(long, env("MPC_RECOVERY_GCP_PROJECT_ID"))] | |||
There was a problem hiding this comment.
Is it the same ID I have added in my PR? Let's delete it, if so.
There was a problem hiding this comment.
No, that's the GCP project id (currently we use pagoda-discovery-platform-dev). It's needed for integration tests where I am using an emulated GCP project with a different name.
|
Let's not merge this until Datastore is up on our GCP project so that we don't break the dev environment (assuming other teams still depend on it for testing their stuff). Also, should probably come in after #97 as that is a more substantial change, and I want to minimize the number of conflicts to resolve. |
itegulov
changed the title
itegulov
changed the title
|
@DavidM-D could you make sure that whatever I wrote in |
| Err(err) => { | ||
| tracing::error!(?err); | ||
| ( | ||
| StatusCode::INTERNAL_SERVER_ERROR, |
There was a problem hiding this comment.
Nit: this is probably a bad request, not an internal server error
|
|
||
| let combined_pub = to_dalek_combined_public_key(ctx.pk_set).unwrap(); | ||
| let account_id = get_test_claims().get_internal_account_id(); |
There was a problem hiding this comment.
This change makes sense, previously we were just checking against the node signatures, which were identical to the signing signatures
This PR makes the leader node generate random private keys for users and store them in GCP Datastore. The code is quite hefty mainly because of the amount of boilerplate I had to write for protobuf (de)serialization.