fix: various macos issues #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
added a commit
that referenced
this pull request
Apr 25, 2023
Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com> Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com> Co-authored-by: David Millar-Durrant <dmillardurrant@gmail.com> Co-authored-by: Phuong Nguyen <ChaoticTempest@users.noreply.github.com> fix: various macos issues (#125) fix: do not unwrap oauth errors (#126) fix secrets and datastore kind with env (#132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Bumps sleeping time from 2s to 10s to ensure datastore emulator has initialized (ideally we should properly inspect logs for the starting condition, but who has time for that?).
Also adds
.cargo/configthat automatically links homebrew files (needed for GMP). @DavidM-D can you make sure this is not breaking your nix flow?plus some minor cleanups after #103 got merged and we no longer have submodules