Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suffix secrets and datastore kind with env #132

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

itegulov
Copy link
Contributor

Fixes #113

@itegulov itegulov requested review from volovyks and DavidM-D April 25, 2023 11:48
Copy link
Contributor

@DavidM-D DavidM-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itegulov itegulov merged commit 7119f93 into develop Apr 25, 2023
@itegulov itegulov deleted the daniyar/gcp-env branch April 25, 2023 14:13
itegulov added a commit that referenced this pull request Apr 25, 2023
Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com>
Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com>
Co-authored-by: David Millar-Durrant <dmillardurrant@gmail.com>
Co-authored-by: Phuong Nguyen <ChaoticTempest@users.noreply.github.com>
fix: various macos issues (#125)
fix: do not unwrap oauth errors (#126)
fix secrets and datastore kind with env (#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametrize node by its environment (dev, prod etc)
2 participants