Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate bs58 Upgrade #1392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Alternate bs58 Upgrade #1392

wants to merge 3 commits into from

Conversation

bh2smith
Copy link

@bh2smith bh2smith commented Sep 28, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I have been getting annoyed by this package resolution warning:

warning near-api-js > @near-js/utils > bs58 > base-x@2.0.6: use 3.0.0 instead, safe-buffer has been merged and release for compatability

Test Plan

Existing CI

Related issues/PRs

This could potentially be a simpler alternative to #1391

Copy link

changeset-bot bot commented Sep 28, 2024

🦋 Changeset detected

Latest commit: 6181277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@near-js/utils Patch
@near-js/accounts Patch
@near-js/biometric-ed25519 Patch
@near-js/client Patch
@near-js/crypto Patch
near-api-js Patch
@near-js/providers Patch
@near-js/transactions Patch
@near-js/wallet-account Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/keystores Patch
@near-js/signers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bh2smith bh2smith changed the title update bs58 Alternate bs58 Upgrade Sep 28, 2024
@r-near r-near mentioned this pull request Nov 23, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

1 participant