Switch to secure Base58 library #1433
Open
+29
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
This PR switches the Base58 implementation to a secure, audited & 0-deps implementation. The existing
bs58
library is old, poorly maintained, and incompatible with Vite due to its use of Node.js primitives (Buffer
).This PR should resolve the following:
Cannot read properties of undefined (reading 'from')
#1420Test Plan
Related issues/PRs
Note
This project still indirectly relies on
bs58
throughnear-workspaces
: