feat: add ed25519_verify host function

[medicz]

No description provided.

[ailisp]

Thank you @medicz. This enhancement looks good to me. Could you fix the CI?

[medicz]

Thank you @medicz. This enhancement looks good to me. Could you fix the CI?

lint CI fixed, audit CI I probably need help with, since it fails on dependencies coming from near-vm-logic, any ideas there?

[chefsale]

cc: @miraclx @ailisp @ChaoticTempest Can you please help with the above blocker?

[miraclx]

Working with SRE to have the rust toolchain inside the buildkite images updated. Will retry the CI run once updated.

[medicz]

@miraclx audit CI fails due to dependency inherited from near-vm-logic 0.16.1. Any advice about this?

[miraclx]

I'll be taking a look at this today! Fingers crossed, this can just be a cargo update resolution and not a full version bump, but I'll report back.

[chefsale]

Seems like checks are passing now. @miraclx @medicz @ailisp @itegulov @ChaoticTempest Can we land this and publish it?

[medicz]

@miraclx any updates about audit CI?

[miraclx]

Apologies for the delay. The Consensus crunch had us prioritize other tasks. But I'm back on this. The status is I'm updating nearcore dependencies to alleviate the vulnerabilities downstream, afterwards, I'll cut a new release of nearcore crates, and revert back. But for clarity, this is being worked on.

[miraclx]

As far as updates go;

• Updated nearcore's dependency on tokio, alleviating the security risk.
• Fixing the nearcore publishing pipeline
  • Patched cargo-workspaces to be compatible with all the new code features nearcore now uses.
  • Reintegrated with nearcore.
  • Updated the nearcore publish process.
  • Investigated and fixed CI run issues.
  • Cut a new release.

[miraclx]

26 days, 7 PRs (to nearcore), 2,056 additions and 667 deletions (to my fork of cargo-workspaces) later, we finally have nearcore's automated publishing process back in the green.

And have just published v0.17.0 of all nearcore primitives.

https://github.com/near/nearcore/releases/tag/crates-0.17.0

[medicz]

@miraclx with introduction of primitives v0.17.0, buildkite needs to be updated to use rust 1.69

[miraclx]

As much as I would've loved to see this through, my time with Pagoda has come to an end.

Hey @frol, can you reach out to SRE to handle this?

[frol]

@medicz I reached out to the SRE team to update Rust on the CI. Yet, there are other issues with this PR that don't seem to be related to the Rust version.

[medicz]

@medicz I reached out to the SRE team to update Rust on the CI. Yet, there are other issues with this PR that don't seem to be related to the Rust version.

indeed, some of those were related to old Cargo.lock being present. Updated in last commit.

[frol]

I finally found a way to update Rust on buildkite (https://buildkite.com/nearprotocol/near-sdk-rs/steps), so it is running now. Still, there are some other changes that I requested above that are important to maintain backward compatibility.

[medicz]

I finally found a way to update Rust on buildkite (https://buildkite.com/nearprotocol/near-sdk-rs/steps), so it is running now. Still, there are some other changes that I requested above that are important to maintain backward compatibility.

@frol PR was updated

[frol]

@medicz Please, fix CI failures

[medicz]

@medicz Please, fix CI failures

fix will have to wait, since problem is deserialisation of contracts on rust 1.70 (see: near/nearcore#9140 (comment) and https://near.org/near/widget/PostPage?accountId=pagodaplatform.near&blockHeight=93538986).

I have also verified that same issue is currently happening on master branch as well.

[frol]

@medicz Let's pin Rust version to 1.69.0 in the GitHub Actions

[medicz]

@medicz Let's pin Rust version to 1.69.0 in the GitHub Actions

@frol pinned

[medicz]

@frol can 4.1.2 be released? It is a blocker for us.

[frol]

@medicz I am working on it. Naive release suggests that there are breaking changes and semver suggests we release 5.0, which I would prefer to avoid doing right now, so I am trying to minimize the scope and see if we can still cut 4.x release.

[ijerkovic]

@frol any news on when the new near-sdk will be released?