Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump crates version to 0.17.0 #9108

Merged
merged 3 commits into from
May 26, 2023
Merged

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented May 25, 2023

Tagged: https://github.com/near/nearcore/releases/tag/crates-0.17.0

A bunch of new crates have been introduced into the workspace that are now expected to be published going forward.

These crates depend on the current state (repo version) of our already published crates which introduces a conflict.

This patch reconsolidates the versions across the workspace to 0.17.0 following a series of fixes to the publishing pipeline.

Check here for a full changelog: crates-0.16.1...crates-0.17.0

@miraclx miraclx requested a review from a team as a code owner May 25, 2023 01:16
@miraclx miraclx requested a review from mzhangmzz May 25, 2023 01:16
@miraclx miraclx requested review from jakmeier and removed request for mzhangmzz May 26, 2023 12:15
@jakmeier
Copy link
Contributor

jakmeier commented May 26, 2023

I welcome a bump of the crates! But I think the release pipeline is still red, it would probably be best if we fix it before we merge a bump.

https://buildkite.com/nearprotocol/nearcore-release/builds/3883#018858a4-be07-4974-84b6-1734f1352cd0/106-625

error[E0433]: failed to resolve: use of undeclared crate or module `near_vm_types`
--> src/artifact.rs:2:5
 |
2 | use near_vm_types::{
  |     ^^^^^^^^^^^^^ use of undeclared crate or module `near_vm_types`

...

error: could not compile `near-vm-vm` due to 26 previous errors
error: unable to publish package near-vm-vm

@Ekleog Can you maybe help out here on Monday?

@miraclx
Copy link
Contributor Author

miraclx commented May 26, 2023

@jakmeier, CI currently fails because it's attempting to publish version 0.16.1 of near-vm-vm, which depends on the previously published 0.16.1 of near-vm-types which had this declaration:

[lib]
name = "wasmer_types"

which was removed in #8862 only after the 0.16.1 release happened.

So this patch will force a general update of all crates to 0.17.0 which should fix this issue in question.

@near-bulldozer near-bulldozer bot merged commit c1b4fec into master May 26, 2023
@near-bulldozer near-bulldozer bot deleted the release/crates-0.17.0 branch May 26, 2023 19:23
@miraclx
Copy link
Contributor Author

miraclx commented May 30, 2023

We're back in the green. 0.17.0 has been cut.

https://buildkite.com/nearprotocol/nearcore-release/builds/3900#01886dc4-0097-4135-8883-cf18ff15a6f9

nikurt pushed a commit that referenced this pull request May 31, 2023
Tagged: https://github.com/near/nearcore/releases/tag/crates-0.17.0

A bunch of new crates have been introduced into the workspace that are now expected to be published going forward.

These crates depend on the current state (repo version) of our already published crates which introduces a conflict.

This patch reconsolidates the versions across the workspace to `0.17.0` following a series of fixes to the publishing pipeline.

Check here for a full changelog: crates-0.16.1...master
@Ekleog
Copy link
Contributor

Ekleog commented Jun 6, 2023

@jakmeier I just saw this 😅 please tag @Ekleog-NEAR if you want a quick reply, otherwise such notifications fall into my personal account's OSS contributions folder, that's way overwhelmed and that I check pretty rarely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants