fix(vector): Update legacy vector to optimize nth operations on iterators #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
ChaoticTempest
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #626 The existing vector iterator is very unoptimized because the map iterator removes the nth implementation, meaning any pagination will iterate all elements. This led us to recommend ugly patterns such as https://www.near-sdk.io/contract-structure/collections#pagination-with-persistent-collections when you should have been able to just use iterators with
skipandtake.Since this
Vectoris used in legacy Unordered collections, I think this is a high leverage change, which is completely backwards compatible. Considering even backporting this as a patch version to the v3 so it doesn't require an upgrade to use it.Just to be clear, this is not a problem with the
store::Vector, just this legacy one.