fix: Optimize nth implementation for legacy UnorderedMap #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the change minimally invasive since this is somewhat of a legacy collection. The new ones are optimized and I assumed that
zip
with the optimization done to #634 would be applied to theUnorderedMap
, but it wasn't.exposes
unordered_map
module to allowIter
type to be used. Didn't add iterator types to others since no demand. There would be a benefit (in that the aux iterator traits would be available) but I don't want to returnvector::Iter
for backwards compatibility if we wanted to switch later and didn't want to just add a bunch of redundant code for no strong reason.