Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable jemalloc support in rocksdb #6290

Closed
matklad opened this issue Feb 14, 2022 · 2 comments · Fixed by #7456
Closed

Enable jemalloc support in rocksdb #6290

matklad opened this issue Feb 14, 2022 · 2 comments · Fixed by #7456
Assignees
@mina86 @nikurt
Labels
Node Node team P-medium Priority: medium T-node Team: issues relevant to the node experience team

Comments

@matklad
Copy link
Contributor

matklad commented Feb 14, 2022 •
edited by exalate-issue-sync bot
Loading

After #6289, we should be able to take advantage of rust-rocksdb/rust-rocksdb#542 – making rocks aware that the allocator we use is jemalloc. Intuitively, it seems like that might bring some substantional perf wins.
@matklad matklad added the T-node Team: issues relevant to the node experience team label Feb 14, 2022
@matklad matklad mentioned this issue Feb 14, 2022
Merged
@bowenwang1996
Copy link
Collaborator

Sadly we reverted #6289 as the performance of 0.18 is worse than that of 0.16 according to our benchmark

@nikurt nikurt self-assigned this Jun 14, 2022
@exalate-issue-sync exalate-issue-sync bot added the P-medium Priority: medium label Aug 11, 2022
@akhi3030
Copy link
Collaborator

#6351 upgraded back to 0.18. We have been running on 0.18 for some time now.

@mina86 mina86 mentioned this issue Sep 6, 2022
Merged
near-bulldozer bot pushed a commit that referenced this issue Sep 19, 2022
@akhi3030
Use jemalloc in rocksdb (#7456)
aaf3797 
We’re using jemalloc in Rust code so it makes sense to do the same in
RocksDB.

Fixes: #6290
nikurt pushed a commit that referenced this issue Nov 9, 2022
@akhi3030 @nikurt
Use jemalloc in rocksdb (#7456)
9ebc7e6 
We’re using jemalloc in Rust code so it makes sense to do the same in
RocksDB.

Fixes: #6290
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mina86 mina86

@nikurt nikurt

Labels
Node Node team P-medium Priority: medium T-node Team: issues relevant to the node experience team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use jemalloc in rocksdb akhi3030/nearcore
6 participants
@mina86 @gmilescu @matklad @akhi3030 @bowenwang1996 @nikurt