Upgrade rust-rocksdb from 0.16 to 0.18 #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Upgrade rust-rocksdb 0.16 to 0.18 * zlib causes a linker failure in librocksdb_sys * . * . * Disable bzip2 feature * fmt
EdvardD
requested review from
bowenwang1996,
mm-near,
olonho,
jakmeier and
khorolets
as code owners
nagisa
reviewed
Feb 25, 2022
nikurt
approved these changes
Feb 25, 2022
nagisa
reviewed
Feb 25, 2022
nagisa
reviewed
Feb 25, 2022
nagisa
reviewed
Feb 25, 2022
nagisa
approved these changes
Feb 25, 2022
mina86
reviewed
Feb 25, 2022
jakmeier
approved these changes
Feb 25, 2022
mm-near
approved these changes
Feb 28, 2022
EdvardD
commented
Mar 1, 2022
There was a problem hiding this comment.
It turned out to be impossible configuring flags per target (x86_64) so they're passed to rust-rocksdb/librocksdb-sys/build.rs so we do that with [build] unconditionally adding flags for all cpu types. We expect this to not break M1 compilation though.
-Dwarnings flag was moved from Makefile to config.toml so it doesn't override flags specified in the config.
nagisa
reviewed
Mar 1, 2022
nagisa
approved these changes
Mar 1, 2022
bowenwang1996
approved these changes
Mar 1, 2022
mina86
pushed a commit
to mina86/nearcore
that referenced
this pull request
Apr 7, 2022
This is commit 6534625 upstream. Co-authored-by: nikurt <86772482+nikurt@users.noreply.github.com> Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade rust-rocksdb from 0.16 to 0.18;
Make sse4.1, sse4.2 cpu instructions a requirement for running a node.
Brings a log of compilation warnings while compiling on aarch64 because of this issue: rust-lang/cargo#10439.
Commit blocking 0.16->0.18 switch: 'Make SSE inclusion conditional for target features (#526)'
Performance after the change: https://pastebin.com/z0uu0dyg
Performance in master: https://pastebin.com/ECjLFptg