Cap maximum gas price #4308
Merged
Cap maximum gas price #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2021 03:28
Closed
added 2 commits
May 20, 2021 03:33
Longarithm
requested review from
bowenwang1996,
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
bowenwang1996
requested changes
May 20, 2021
|
Added new tests and moved creation of congestion to a separate function |
bowenwang1996
approved these changes
May 24, 2021
chain/client/tests/process_blocks.rs
Outdated
| @@ -77,6 +77,79 @@ pub fn create_nightshade_runtimes(genesis: &Genesis, n: usize) -> Vec<Arc<dyn Ru | |||
| .collect() | |||
| } | |||
|
|
|||
| /// Create environment and set of transactions which cause congestion on the chain. | |||
| fn create_env_with_congestion( | |||
chain/client/tests/process_blocks.rs
Outdated
Comment on lines
2774
to
2783
| env.produce_block(0, i); | ||
| let block = env.clients[0].chain.get_block_by_height(i).unwrap().clone(); | ||
| let protocol_version = env.clients[0] | ||
| .runtime_adapter | ||
| .get_epoch_protocol_version(block.header().epoch_id()) | ||
| .unwrap(); | ||
| let min_gas_price = | ||
| env.clients[0].chain.block_economics_config.min_gas_price(protocol_version); | ||
| if block.header().gas_price() > 10 * min_gas_price { | ||
| return true; |
There was a problem hiding this comment.
Please also assert that congestion actually happens. You can do this by asserting that gas usage is at least as large as gas limit.
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jun 7, 2021
- Actually update nightly protocol version to catch CapMaxGasPrice feature which I forgot to do here: #4308 - Fix tests for `RestoreReceiptsAfterFix` feature started failing after it. Reason: protocol feature have to be set in produced blocks explicitly like in `storage_usage_fix_tests`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cap maximum gas price: #4302
Test plan
test_cap_max_gas_pricechecks thatmax_gas_price <= 10 * min_gas_pricefor the new protocol version.process_blocks.rs:cap_max_gas_price_testscheck thatgas_pricemay exceed10 * min_gas_pricefor the old protocol version but may not for the new one.