Take CapMaxGasPrice feature on nightly #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bowenwang1996 |
added 4 commits
June 7, 2021 14:38
Longarithm
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
EgorKulikov
approved these changes
Jun 7, 2021
bowenwang1996
approved these changes
Jun 7, 2021
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
In #4348 we set the maximum gas price to be 10 * minimum gas price. However, one issue with this change is that it changes max gas price to be 10^9 yotcoNEAR, which means that per block max cost is 1N (10^9 yotcoNEAR/gas * 10^15 gas) and this means in a year the maximal burnt tokens in transaction fees is ~31 million NEAR, which will still be smaller than the total inflation (~50 million NEAR). This PR changes the multiplier to 20x to ensure that the network at least does not inflate at maximal capacity. Note that not changing nightly protocol version is intentional here -- there is no congestion on betanet anyways and we don't need to do a hard fork there. Test plan ---------- Existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestoreReceiptsAfterFixfeature started failing after it. Reason: protocol feature have to be set in produced blocks explicitly like instorage_usage_fix_tests