-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use nextest for better test isolation #8207
Conversation
3d2a0c5
to
17deacd
Compare
331bd72
to
917355e
Compare
+1 for enabling this to set timeout for individual unit tests. I was debugging flaky |
I would argue that we want to adjust documentation to inform developers to use |
+1. Please add some documentation in https://near.github.io/nearcore/practices/testing/index.html (https://github.com/near/nearcore/tree/master/docs/practices/testing) |
We have that already, even though we are using the same test harness in CI and locally. Updated documentation. |
it will allow us to set panic=abort per test (because each test is executed in a separate subprocess) and set test timeouts without developing a custom test harness. Additionally I've set the default test timeout to 2min (period = 1min, killing test after 2 periods), which seems reasonable, given that all presubmit tests execute <1min as of today.
it will allow us to set panic=abort per test (because each test is executed in a separate subprocess) and set test timeouts without developing a custom test harness. Additionally I've set the default test timeout to 2min (period = 1min, killing test after 2 periods), which seems reasonable, given that all presubmit tests execute <1min as of today.