Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JupyterHub 5/App Launcher Styling Issues #291

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix JupyterHub 5/App Launcher Styling Issues #291

merged 2 commits into from
May 28, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented May 24, 2024 •
edited
Loading

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-05-28 at 8 33 42 AM Screenshot 2024-05-28 at 8 34 02 AM Screenshot 2024-05-28 at 8 34 18 AM Screenshot 2024-05-28 at 8 34 48 AM

Any other comments?

@vercel Vercel
Copy link

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:31am
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:31am

@jbouder jbouder marked this pull request as ready for review May 28, 2024 12:32
@krassowski
Copy link
Member

krassowski commented May 28, 2024 •
edited
Loading

Just FYI, made some changes in the nebari-jupyterhub-theme for JHub 5.0 in nebari-dev/nebari-jupyterhub-theme#21, from diff in this RP it looks like there is no overlap/conflicts whatsoever

kildre
kildre approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aktech aktech merged commit 9c70cbf into nebari-dev:main May 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kildre kildre kildre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbouder @krassowski @kildre @aktech