Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu styling on JupyterHub 5.0, require 5.0 #21

Merged
merged 4 commits into from
May 27, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 27, 2024

Reference Issues or PRs

Fixes #20

Before After
image image

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski marked this pull request as ready for review May 27, 2024 09:08
@krassowski
Copy link
Member Author

krassowski commented May 27, 2024

Looking at an older deployment I see that the top bar used to be dark prior to JHub 5 and that now the nebari logo text is not visible. Before:

image

@krassowski krassowski marked this pull request as draft May 27, 2024 16:25
@krassowski
Copy link
Member Author

OK, looking good now I believe:

theme

@krassowski krassowski marked this pull request as ready for review May 27, 2024 17:42
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski !

@marcelovilla marcelovilla merged commit 705c5e4 into nebari-dev:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Spacing of menu items in JupyterHub 5
2 participants