Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Fix traefik certificates from letsencrypt and tlsstore #1015

Closed
viniciusdc opened this issue Feb 3, 2022 · 0 comments · Fixed by #1017
Closed

[bug] Fix traefik certificates from letsencrypt and tlsstore #1015

viniciusdc opened this issue Feb 3, 2022 · 0 comments · Fixed by #1017
Assignees
@costrouc
Labels
area: integration/keycloak status: in progress 🏗 This task is currently being worked on type: bug 🐛 Something isn't working
Milestone
Release v0.4.0

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Feb 3, 2022 •
edited
Loading

Description

With the recent changes made for #1003, we refactored the way certs are stored and passed over the qhub configuration (terraform modules, services..). This issue aims to fix any related problems that showed up regarding those changes.
@viniciusdc viniciusdc added this to the Release v0.4.0 milestone Feb 3, 2022
costrouc added a commit that referenced this issue Feb 3, 2022
@costrouc
Fix issue with traefik issueing certificates with letsencrypt acme
2ce517d 
The core of the issue was that for entrypoints a default certResolver
was not being specified. Additionally had to read some docs within
traefik https://doc.traefik.io/traefik/routing/entrypoints/#tls that
state that is a `tls = {}` section is specified within the crd
ingressroute the tls configuration is overwritten.

```
If a TLS section (i.e. any of its fields) is user-defined, then the
default configuration does not apply at all.
```

Related to #1015
@costrouc costrouc mentioned this issue Feb 3, 2022
Merged
12 tasks
@viniciusdc viniciusdc changed the title [enhancement] Fix traefik certificates from letsencrypt and tlsstore [bug] Fix traefik certificates from letsencrypt and tlsstore Feb 3, 2022
@viniciusdc viniciusdc added the type: bug 🐛 Something isn't working label Feb 3, 2022
costrouc added a commit that referenced this issue Feb 3, 2022
@costrouc
Fix issue with traefik issueing certificates with letsencrypt acme
c6dd07c 
The core of the issue was that for entrypoints a default certResolver
was not being specified. Additionally had to read some docs within
traefik https://doc.traefik.io/traefik/routing/entrypoints/#tls that
state that is a `tls = {}` section is specified within the crd
ingressroute the tls configuration is overwritten.

```
If a TLS section (i.e. any of its fields) is user-defined, then the
default configuration does not apply at all.
```

Related to #1015
iameskild pushed a commit that referenced this issue Feb 4, 2022
@costrouc
Fix issue with traefik issueing certificates with letsencrypt acme (#…
1b26b8b 
…1017)

* Fix issue with traefik issueing certificates with letsencrypt acme

The core of the issue was that for entrypoints a default certResolver
was not being specified. Additionally had to read some docs within
traefik https://doc.traefik.io/traefik/routing/entrypoints/#tls that
state that is a `tls = {}` section is specified within the crd
ingressroute the tls configuration is overwritten.

```
If a TLS section (i.e. any of its fields) is user-defined, then the
default configuration does not apply at all.
```

Related to #1015

* Adding docs on testing certificates

* Adding vale suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costrouc costrouc

Labels
area: integration/keycloak status: in progress 🏗 This task is currently being worked on type: bug 🐛 Something isn't working
Projects
None yet
Milestone
Release v0.4.0
Development

Successfully merging a pull request may close this issue.

Fix issue with traefik issueing certificates with letsencrypt acme nebari-dev/nebari
2 participants
@costrouc @viniciusdc