Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with traefik issueing certificates with letsencrypt acme #1017

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 3, 2022

The core of the issue was that for entrypoints a default certResolver
was not being specified. Additionally had to read some docs within
traefik https://doc.traefik.io/traefik/routing/entrypoints/#tls that
state that is a tls = {} section is specified within the crd
ingressroute the tls configuration is overwritten.

If a TLS section (i.e. any of its fields) is user-defined, then the
default configuration does not apply at all.

Fixes #1015

Changes:

  • changes related to traefik ingress

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Tested locally using minikube and using digitalocean

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@costrouc costrouc requested a review from viniciusdc February 3, 2022 17:01
@costrouc
Copy link
Member Author

costrouc commented Feb 3, 2022

Still need to test with custom secret for compatibility. So do not merge until this is tested.

The core of the issue was that for entrypoints a default certResolver
was not being specified. Additionally had to read some docs within
traefik https://doc.traefik.io/traefik/routing/entrypoints/#tls that
state that is a `tls = {}` section is specified within the crd
ingressroute the tls configuration is overwritten.

```
If a TLS section (i.e. any of its fields) is user-defined, then the
default configuration does not apply at all.
```

Related to #1015
@costrouc
Copy link
Member Author

costrouc commented Feb 3, 2022

Tested and this appears to be working great with all three methods of creating certificates. This also appears to fix the dask-gateway issue when visiting the link. With the exception that self signed certificates are not trusted. This is due to issue thomseddon/traefik-forward-auth#122. So the dashboards for now will only work for trusted certificates.

@iameskild iameskild merged commit 1b26b8b into main Feb 4, 2022
@iameskild iameskild deleted the fix-1015-traefik branch February 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Fix traefik certificates from letsencrypt and tlsstore
3 participants