Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates/fixes for rendering CICD workflows #1086

Merged
merged 9 commits into from
Feb 22, 2022
Merged

Updates/fixes for rendering CICD workflows #1086

merged 9 commits into from
Feb 22, 2022

Conversation

iameskild
Copy link
Member

@iameskild iameskild commented Feb 21, 2022

Fixes | Closes | Resolves #

Please remove anything marked as optional that you don't need to fill in. Choose one of the keywords preceding to refer to the issue this PR solves, followed by the issue number (e.g Fixes # 666). If there is no issue, remove the line. Remove this note after reading.

Changes:

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@iameskild
Copy link
Member Author

iameskild commented Feb 21, 2022

Testing completed for: ci-provider==

  • github-actions
  • gitlab-ci

@iameskild iameskild mentioned this pull request Feb 22, 2022
92 tasks
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iameskild I was in need of those changes!!!

@iameskild iameskild merged commit 9dcdb0f into main Feb 22, 2022
@iameskild iameskild deleted the 20220221eae branch February 22, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants