Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the commit of the terraform rendering optional #995

Closed
wants to merge 1 commit into from

Conversation

leej3
Copy link
Contributor

@leej3 leej3 commented Jan 17, 2022

Combined with #720 this enables deployment of QHub with gitops in such a way that secrets are not committed back to the repository.

@viniciusdc
Copy link
Contributor

@iameskild was this added on #1086 ?

@iameskild
Copy link
Member

@viniciusdc I'm sorry I didn't include this change in the original PR (even though you reminded me 😅). I have opened PR #1149 that replaces this one...

@costrouc
Copy link
Member

costrouc commented Mar 8, 2022

Closes by #1149

@costrouc costrouc closed this Mar 8, 2022
@trallard trallard deleted the make_commit_of_render_optional branch October 7, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants