Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API docs #1511

Closed
wants to merge 19 commits into from
Closed

Add API docs #1511

wants to merge 19 commits into from

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Oct 25, 2022

Fixes | Closes | Resolves #

Changes introduced in this PR:

  • add api doc md file
  • add script to generate md file
  • add gh workflow to autogenerate docs

Types of changes

What types of changes does your PR introduce?

  • Documentation Update

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@kcpevey
Copy link
Contributor Author

kcpevey commented Oct 25, 2022

There is a sister PR on the nebari-docs repo to add it this actual file to the documentation. I still need to add a separate GH action to open the PR on the nebari-docs repo

@trallard trallard added this to the 🪴 Nebari rename milestone Oct 26, 2022
@kcpevey kcpevey mentioned this pull request Oct 27, 2022
13 tasks
@aktech aktech changed the base branch from main to release/2022.11.1 November 30, 2022 15:38
@aktech
Copy link
Member

aktech commented Nov 30, 2022

/bot run tests

@github-actions
Copy link

Contributor Tests Triggered by @aktech

@costrouc
Copy link
Member

There is a sister PR on the nebari-docs repo to add it this actual file to the documentation. I still need to add a separate GH action to open the PR on the nebari-docs repo

@kcpevey is this PR ready for review or testing? Looks like you said it depends on nebari-docs?

@kcpevey
Copy link
Contributor Author

kcpevey commented Dec 14, 2022

@costrouc this is ready for review.

Now that I'm looking at it, it could use some updating since it was pre-rename.

@iameskild iameskild changed the base branch from release/2022.11.1 to develop December 14, 2022 19:45
@pavithraes pavithraes self-requested a review December 21, 2022 11:23
@trallard trallard added the status: in progress 🏗 This task is currently being worked on label Jan 10, 2023
pyproject.toml Outdated Show resolved Hide resolved
@kcpevey
Copy link
Contributor Author

kcpevey commented Jan 24, 2023

@trallard this is still failing to find the secret called NEBARI_SENSEI_API_DOCS_PR_OPENER. Has it been added here? I dont have permissions to check.

@aktech
Copy link
Member

aktech commented Jan 24, 2023

The secret is already added, but it won't be accessible by actions run by PR from forks. We would need to trigger via contributor tests:

Screenshot 2023-01-24 at 6 30 10 pm

@kcpevey
Copy link
Contributor Author

kcpevey commented Jan 24, 2023

Thanks @aktech. I'll look into that.

@kcpevey kcpevey mentioned this pull request Jan 31, 2023
3 tasks
@kcpevey
Copy link
Contributor Author

kcpevey commented Jan 31, 2023

This is being superseded by #1634

@kcpevey kcpevey closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants