Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API docs #1634

Merged
merged 39 commits into from
Sep 12, 2023
Merged

Add API docs #1634

merged 39 commits into from
Sep 12, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Jan 31, 2023

Changes introduced in this PR:

  • add api doc md file
  • add script to generate md file
  • add gh workflow to autogenerate docs

Reference Issues or PRs

Partially resolves nebari-dev/nebari-docs#157

What does this implement/fix?

  • Documentation Update

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

There is a sister PR on the nebari-docs repo to add it this actual file to the documentation. I still need to add a separate GH action to open the PR on the nebari-docs repo

This PR supercedes this one which was failing due to credentials access via a fork.

@kcpevey kcpevey mentioned this pull request Jan 31, 2023
8 tasks
@kcpevey kcpevey requested a review from iameskild February 1, 2023 14:59
@kcpevey kcpevey mentioned this pull request Feb 1, 2023
@kcpevey kcpevey added area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing impact: low 🟩 Minimally disruptive or niche labels Feb 7, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kcpevey I left a few questions and comments but otherwise this is looking good.

I think having API docs will not only be useful for newcomers but for us as maintainers as well. Reviewing the API docs makes it more obvious where we need to make improvements :)

.github/workflows/update_api_docs.yml Outdated Show resolved Hide resolved
docs/api_docs/api_doc.md Outdated Show resolved Hide resolved
@pavithraes pavithraes added this to the Release 2023.2.1 milestone Feb 14, 2023
@pavithraes pavithraes added status: in progress 🏗 This task is currently being worked on and removed needs: review 👀 This PR is complete and ready for reviewing labels Feb 14, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this as much as far as I could on my local machine and I was able to render the API docs cli.html and they look good to me. I left one minor comment but otherwise, I think this is ready to go! Thanks @kcpevey

.github/workflows/generate_cli_doc.yml Show resolved Hide resolved
@kcpevey
Copy link
Contributor Author

kcpevey commented May 9, 2023

I will try to bring this up to date with the CI fixes on develop this week.

@iameskild
Copy link
Member

Hi @kcpevey, this should be ready to merge right? CI is failing at the moment because the DigitalOcean token has expired (I lack the access at the moment to update it) but once the kubernetes test passes, I'm good with merging this :)

@iameskild iameskild added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: review 👀 This PR is complete and ready for reviewing labels May 18, 2023
@iameskild
Copy link
Member

@kcpevey is this PR ready to merge? If you're busy, I can wrap this up.

@kcpevey
Copy link
Contributor Author

kcpevey commented Jul 6, 2023

This should be ready to go.

@iameskild
Copy link
Member

Hey @kcpevey, do you have time this week to resolve the merge conflicts? Once that's done, I believe this can be merged :)

@iameskild
Copy link
Member

Hey @kcpevey, this looks like it's really close, do you have a few minutes to help resolve this conflicts? Once that's done, we can merge this PR.

@kcpevey
Copy link
Contributor Author

kcpevey commented Aug 4, 2023

I struggled a good bit trying to get Typer to render like I wanted. The sphinx extension sphinx-click does a good job, but there are still two issues that have no resolution at this point.

  1. The rich markdown coloring of the help docs is not understood by sphinx-click. This is a known issue marked low priority in sphinx-click (rich markup shows when using sphinx-click ewels/rich-click#48).
  2. The name of the program appears to be main. I tried renaming the files, setting prog_name (Support passing prog_name fastapi/typer#120), renaming the imports, and a bunch of other things but didn't find a solution.

I'm not sure how people feel about these "warts". I could programmatically do some find/replace on the output html, or we can accept as is.

image

@pavithraes pavithraes mentioned this pull request Aug 7, 2023
@pavithraes pavithraes self-requested a review August 8, 2023 14:17
@pavithraes pavithraes added needs: review 👀 This PR is complete and ready for reviewing and removed status: approved 💪🏾 This PR has been reviewed and approved for merge labels Aug 8, 2023
@kcpevey kcpevey merged commit 3238856 into develop Sep 12, 2023
@kcpevey kcpevey deleted the api_docs branch September 12, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation impact: low 🟩 Minimally disruptive or niche needs: review 👀 This PR is complete and ready for reviewing
Projects
Development

Successfully merging this pull request may close these issues.

[DOC] - Nebari API docs
5 participants