-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API docs #1634
Add API docs #1634
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kcpevey I left a few questions and comments but otherwise this is looking good.
I think having API docs will not only be useful for newcomers but for us as maintainers as well. Reviewing the API docs makes it more obvious where we need to make improvements :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this as much as far as I could on my local machine and I was able to render the API docs cli.html
and they look good to me. I left one minor comment but otherwise, I think this is ready to go! Thanks @kcpevey
I will try to bring this up to date with the CI fixes on develop this week. |
Hi @kcpevey, this should be ready to merge right? CI is failing at the moment because the DigitalOcean token has expired (I lack the access at the moment to update it) but once the kubernetes test passes, I'm good with merging this :) |
@kcpevey is this PR ready to merge? If you're busy, I can wrap this up. |
This should be ready to go. |
Hey @kcpevey, do you have time this week to resolve the merge conflicts? Once that's done, I believe this can be merged :) |
Hey @kcpevey, this looks like it's really close, do you have a few minutes to help resolve this conflicts? Once that's done, we can merge this PR. |
I struggled a good bit trying to get Typer to render like I wanted. The sphinx extension
I'm not sure how people feel about these "warts". I could programmatically do some find/replace on the output html, or we can accept as is. |
Changes introduced in this PR:
Reference Issues or PRs
Partially resolves nebari-dev/nebari-docs#157
What does this implement/fix?
Testing
Any other comments?
There is a sister PR on the nebari-docs repo to add it this actual file to the documentation. I still need to add a separate GH action to open the PR on the nebari-docs repo
This PR supercedes this one which was failing due to credentials access via a fork.