Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JHub Apps: Filter conda envs by user #2187

Merged
merged 4 commits into from
Jan 10, 2024
Merged

JHub Apps: Filter conda envs by user #2187

merged 4 commits into from
Jan 10, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Jan 8, 2024

Reference Issues or PRs

At the moment it returns all the environments even if the user doesn't have access to it.
Ref: nebari-dev/jhub-apps#51

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added this to the 2024.1.1 milestone Jan 9, 2024
@@ -63,6 +65,7 @@ def get_conda_store_environments(query_package: str = ""):
"/usr/local/etc/jupyterhub/jupyterhub_config.py"
)
c.JAppsConfig.hub_host = "hub"
c.JAppsConfig.service_workers = 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aktech What is going on with this line? It seems unrelated to the issue.

Copy link
Member Author

@aktech aktech Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is unrelated. This is harnessing the new feature being able to configure workers for jhub-apps service. I thought I would add all jhub apps related settings in this PR, but happy to create a new PR for this.

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only allows users to use environments from their personal namespace, not from any shared namespace that they have access to. We need to give them access to any env that they have access to imo.

@aktech
Copy link
Member Author

aktech commented Jan 9, 2024

This only allows users to use environments from their personal namespace, not from any shared namespace that they have access to. We need to give them access to any env that they have access to imo.

Yes, spot on. That would be ideal, but in the best interest of time, I chose to not tackle it in this release.

@aktech
Copy link
Member Author

aktech commented Jan 10, 2024

Created an issue to tackle the later in next release: #2193

@dcmcand dcmcand merged commit 0d02ab4 into develop Jan 10, 2024
26 of 27 checks passed
@dcmcand dcmcand deleted the conda-env-per-user branch January 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants