-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JHub Apps: Filter conda envs by user #2187
Conversation
@@ -63,6 +65,7 @@ def get_conda_store_environments(query_package: str = ""): | |||
"/usr/local/etc/jupyterhub/jupyterhub_config.py" | |||
) | |||
c.JAppsConfig.hub_host = "hub" | |||
c.JAppsConfig.service_workers = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aktech What is going on with this line? It seems unrelated to the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is unrelated. This is harnessing the new feature being able to configure workers for jhub-apps service. I thought I would add all jhub apps related settings in this PR, but happy to create a new PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only allows users to use environments from their personal namespace, not from any shared namespace that they have access to. We need to give them access to any env that they have access to imo.
Yes, spot on. That would be ideal, but in the best interest of time, I chose to not tackle it in this release. |
Created an issue to tackle the later in next release: #2193 |
Reference Issues or PRs
At the moment it returns all the environments even if the user doesn't have access to it.
Ref: nebari-dev/jhub-apps#51
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?