Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all environments instead of just those under the user's namespace for jhub-apps #2206

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

marcelovilla
Copy link
Member

For the time being, we'll return all the environments instead of just those under the user's namespace for jhub-apps. In the future, we'd like to expose a way of filtering all the environments a specific user has access to from conda-store.

Reference Issues or PRs

#2193

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@marcelovilla marcelovilla requested a review from aktech January 16, 2024 22:40
@marcelovilla
Copy link
Member Author

@aktech I'm actually not sure whether I should rollback all the changes (except from the service_workers configuration) in https://github.com/nebari-dev/nebari/pull/2187/files?diff=unified&w=0 or just the returned values of the function.

@aktech
Copy link
Member

aktech commented Jan 17, 2024

@aktech I'm actually not sure whether I should rollback all the changes (except from the service_workers configuration) in #2187 (files) or just the returned values of the function.

Service workers change doesn't needs to be rolled back, see #2187 (comment)

@aktech aktech merged commit d206cfd into develop Jan 17, 2024
26 of 27 checks passed
@aktech aktech deleted the rollback-spawner-env-list branch January 17, 2024 16:50
@marcelovilla
Copy link
Member Author

@aktech I meant the function signature which used to accept a query_package argument instead of the user_info dict:

def get_conda_store_environments(query_package: str = ""):

I assume it was not necessary as you already merged the PR but please confirm that's the case.

@aktech
Copy link
Member

aktech commented Jan 17, 2024

@marcelovilla yes, I misread your comment. That is not required. What you have is absolutely correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants