-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and extend Playwright tests #2644
Refactor and extend Playwright tests #2644
Conversation
Tests are failing due to the problem outlined in #2643, but we can still validate the playwright tests are now working: video_test_login_logout.mp4video_test_navbar_services.mp4video_test_notebook.mp4video_test_conda_store_ui.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @viniciusdc! I think this is a good first step in refactoring our tests and making them more extensible.
Regarding issue #2020, I'd say this PR does not necessarily closes it as based on the description, we also want to test environment creation and build deletion. I'm not saying we need to address that right away in this PR and I'll let you decide whether it should be closed or not.
@@ -172,7 +172,7 @@ jobs: | |||
# create environment file | |||
envsubst < .env.tpl > .env | |||
# run playwright pytest tests in headed mode with the chromium browser | |||
xvfb-run pytest --browser chromium | |||
xvfb-run pytest --browser chromium --slowmo 300 --headed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viniciusdc is there any downside of having the --slowmo
flag here? Based on your commit messages, I'm guessing you added it to allow some time for the notebook to load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only downside would be that all related playwright actions within a test (click a button, query, refresh etc) will take a slight increase in execution time which in return increases the time for the overall playwright pytest suit to complete -- though, I advice that this is essential for some components to load properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the increase in execution time won't really be a significant issue. I'm more concerned with whether the appropriate way of dealing with components loading would be to use the wait_for_load_state
(or similar) method directly within the playwright page.
I'll let you decide what's best and I don't think we need to implement everything in this PR anyways. Thanks Vini!
@marcelovilla, good point; I will remove that closing tag and add a simple ref. Instead, I saw a note from @kcpevey on recent playwright tests added to conda-store; I was going to open a follow-up issue to extend this base class, as the main goal for this one was to at least catch the problem with starting the plugin at all. |
Reference Issues or PRs
related to #2020
closes #2642
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?
I will open a follow-up PR to extend the conda-store test suit based on @kcpevey suggestion #2020 (comment)