-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor jupyterhub user token retrieval within pytest #2645
Merged
viniciusdc
merged 6 commits into
nebari-dev:develop
from
viniciusdc:2643-cookie-conflict
Aug 30, 2024
Merged
refactor jupyterhub user token retrieval within pytest #2645
viniciusdc
merged 6 commits into
nebari-dev:develop
from
viniciusdc:2643-cookie-conflict
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytests are passing, playwright-related tests should be fixed by #2644, though I expect this PR to be merged first
and
|
10 tasks
marcelovilla
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viniciusdc !
blocked by #2672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
closes #2643
closes #2641
What does this implement/fix?
CookieConflictError
exception to handle duplicate cookies entries during jupyterhub authentication;Put a
x
in the boxes that applyTesting
Any other comments?