Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: skip failure on cleanup #910

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix CI: skip failure on cleanup #910

merged 1 commit into from
Nov 10, 2021

Conversation

aktech
Copy link
Member

@aktech aktech commented Nov 10, 2021

Fixes | Closes | Resolves #

This skips the failure on the cleanup step to remove noise from the CI.

Changes:

  • Updated the AMI with cypress dependencies to reduce time in installation: ami-0ff297f01f579288c

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@aktech
Copy link
Member Author

aktech commented Nov 10, 2021

The pull request for pytest type tests will follow up after this. The goal of this PR is to make CI green again and remove noise from CI failure due to failure in qhub cleanup, we can fix the qhub cleanup eventually, but it would be better for now to give correct feedback on people's PR.

@aktech aktech requested a review from costrouc November 10, 2021 06:15
@costrouc costrouc merged commit b86e32c into main Nov 10, 2021
@costrouc costrouc deleted the fix-tests branch November 10, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants