Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: skip failure on cleanup #910

Merged
merged 1 commit into from
Nov 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cirun.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ runners:
# Instance Type has 4 vcpu, 16 GiB memory, Up to 5 Gbps Network Performance
instance_type: t3a.xlarge
# Custom AMI with docker is pre-installed
machine_image: ami-08939857cf6893cde
machine_image: ami-0ff297f01f579288c
# Region: Oregon
region: us-west-2
# Path of the relevant workflow file
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/kubernetes_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
cd local-deployment
qhub deploy --config qhub-config.yaml --disable-prompt
- name: Basic kubectl checks after deployment
if: always()
run: |
kubectl get all,cm,secret,ing -A
- name: Check github-actions.qhub.dev resolves
Expand Down Expand Up @@ -150,7 +151,10 @@ jobs:
- name: Cleanup qhub deployment
run: |
cd local-deployment
qhub destroy --config qhub-config.yaml
# This is a known failure at the moment.
qhub destroy --config qhub-config.yaml || true

- name: Basic kubectl checks after cleanup
if: always()
run: |
kubectl get all,cm,secret,ing -A
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,9 @@ module "qhub" {
keycloak_password = random_password.keycloak-qhub-bot-password.result
keycloak_server_url = "http://keycloak-headless.${var.environment}:8080/auth/"

depends_on = [
module.kubernetes-initialization
]
}

{% if cookiecutter.prefect.enabled -%}
Expand Down Expand Up @@ -380,4 +383,7 @@ module "forwardauth" {
jh-client-id = local.forwardauth-keycloak-client-id
jh-client-secret = random_password.forwardauth-jhsecret.result
callback-url-path = local.forwardauth-callback-url-path
depends_on = [
module.kubernetes-initialization
]
}