Deprecate existing coupon codes methods #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Oct 26, 2018
There was a problem hiding this comment.
Great job, left some comment about some possibile improvements.
Before this to be completed I think we should get rid of all the expect(Spree::Deprecation).to receive(:warn) from feature specs. I'm thinking at the cart ones, there's no real replacement of this right now so maybe we need to implement a way to apply coupon code via API first, as it's done in the checkout.
What do you think?
| @@ -20,6 +20,7 @@ module Spree::Api | |||
|
|
|||
| it "can apply a coupon code to the order" do | |||
There was a problem hiding this comment.
this tests look like duplicated of what we have here, right? If yes, maybe we can do another PR to remove duplication?
aitbw
force-pushed
the
nebulab/deprecate_coupon_code_methods
branch
4 times, most recently
from
4609d98 to
d27596f
Compare
aitbw
changed the title
kennyadsl
reviewed
Nov 17, 2018
|
Also, we can maybe squash some commits together? |
aitbw
force-pushed
the
nebulab/deprecate_coupon_code_methods
branch
from
d68f38c to
70b3f36
Compare
aitbw
force-pushed
the
nebulab/deprecate_coupon_code_methods
branch
from
66eac4c to
4559a00
Compare
|
Closing now that solidusio#2958 is merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @kennyadsl's idea on solidusio#2327, this PR aims to deprecate current endpoints used to apply coupon codes (on orders and checkout) and replace them with a new API controller/endpoint properly named
Spree::Api::CouponCodesController.I think this approach allows a better separation of concerns and it's easier to reason about. Plus, it'd be easier to implement a built-in solution for solidusio#1641.
That said, we're still missing a
Spree::CouponCodesControllercontroller/endpoint under/frontendbut since we're already using API calls under said folder, I still debating whether to implement that or not.I'm open to suggestions!