Deprecate existing coupon codes methods #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
nebulab/deprecate_coupon_code_methods
branch
from
66eac4c to
4559a00
Compare
kennyadsl
reviewed
Nov 20, 2018
|
Noted @kennyadsl 👌 let me have a look on that |
kennyadsl
reviewed
Nov 20, 2018
aitbw
added a commit
to aitbw/solidus_tax_cloud
that referenced
this pull request
Jan 29, 2019
solidusio/solidus#2958 replaced `order_coupon_code` text field for `coupon_code`, which broke master build. This patch fixes this regression.
aitbw
added a commit
to aitbw/solidus_tax_cloud
that referenced
this pull request
Jan 29, 2019
solidusio/solidus#2958 replaced `order_coupon_code` text field for `coupon_code`, which broke master build. This patch fixes this regression.
aitbw
added a commit
to aitbw/solidus_tax_cloud
that referenced
this pull request
Jan 29, 2019
solidusio/solidus#2958 replaced `order_coupon_code` text field for `coupon_code`, which broke master build. This patch fixes this regression.
aitbw
added a commit
to aitbw/solidus_tax_cloud
that referenced
this pull request
Jan 29, 2019
solidusio/solidus#2958 replaced `order_coupon_code` text field for `coupon_code`, which broke master build. This patch fixes this regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Following @kennyadsl's idea on #2327, this PR aims to deprecate current endpoints used to apply coupon codes (on orders and checkout) and replace them with a new API endpoint properly named
Spree::Api::CouponCodesController. This was also done for thefrontendwithSpree::CouponCodesController.I think this approach allows a better separation of concerns and it's easier to reason about. Plus, it'd be easier to implement a built-in solution for #1641.
I'm open to suggestions!