[pull] main from solidusio:main #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Currently if a product has the `available_on` date in the future, it will still show a status of Available, even though it is not available for purchase on the store. This change proposes a new status of `Unavailable` for scheduled products. Co-authored-by: Harmony Bouvier <harmony@super.gd>
This change fixes an issue where certain browsers (namely Firefox) will not render the date field correctly when it contains the full date and time format as the value. This change just truncates the available_on and discontinue_on values to match the precision expected, rather switch to the datetime-local input which is not fully supported in all browsers, but also maintains the old admin behaviour. Co-authored-by: Andrew Stewart <andrew@super.gd>
When trying to use the `DB_POSTGRES_HOST` environment variable in some unrelated work, we observed it wasn't changing anything. Co-authored-by: An Stewart <andrew@super.gd>
Prior to this, we would only allow changing the configuration of the promotion system by switching the `promotions_configuration_class`. The `AppConfiguration` would then instantiate that class, and one would be able to do all the necessary customizations via the instance. This allows customizing a promotion configuration and then setting it as the promotion configuration class. It's a lot easier to understand.
Fix case statement in database config template
This adds a configurable promotion advertiser that is supposed to make the code in Spree::Product#possible_promotions not depend on the presence of the current promotion system.
This creates a promotion advertiser class that fulfills the API of the current promotion advertiser and can be used when there's no promotion system configured.
…w-unavailable-status-products Show "Unavailable" status for products with a future `Available On` date
pull
bot
added
⤵️ pull
and removed
changelog:solidus_core
changelog:solidus_admin
labels
The `buster` image is quite old and creates some challenges on newer ARM based Mac's, so we update to `bookworm`. To put this into context, this takes us from a Debian release in Sept 2019 to June 2023. Co-authored-by: An Stewart <andrew@super.gd> Co-authored-by: Chris Todorov <chris@super.gd> Co-authored-by: Alberto Vena <kennyadsl@gmail.com> Co-authored-by: Thomas von Deyen <thomas@vondeyen.com>
This gem has gone end-of-life and we're using a version of Selenium that supports Selenium manager, so there is no reason to keep this gem around. Read more here: https://github.com/titusfortner/webdrivers/blob/44d4c1ae865d0acd30613313b8c67a16711249ac/README.md#update-future-of-this-project Co-authored-by: An Stewart <andrew@super.gd>
Prior to increasing the shared memory size or `shm_size`, we received errors trying to run feature specs due to lack of memory. Co-authored-by: An Stewart <andrew@super.gd>
This allows us to switch out the promotion advertiser.
This removes some promotion-system dependent code from the Spree::Product class.
Node version 14 is quite out of date, but most notably there is a 60 second penalty imposed by NodeSource as a way of warning users to upgrade. Co-authored-by: An Stewart <andrew@super.gd>
Promotion advertiser
Docker development environment improvements
Configure promotions via a configuration instance
Update to Node 20 in `docker-compose.yml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )