Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyCode_GetCode #1394

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Use PyCode_GetCode #1394

merged 1 commit into from
Jun 6, 2022

Conversation

sweeneyde
Copy link
Contributor

Discussed here

@Fidget-Spinner
Copy link

Thanks for the investigation Dennis. Have you tried seeing if it improves anything with the coverage.py benchmarks ?

@sweeneyde
Copy link
Contributor Author

Have you tried seeing if it improves anything with the coverage.py benchmarks ?

I haven't -- I was having trouble getting those to run on Windows.

@kumaraditya303
Copy link

kumaraditya303 commented Jun 6, 2022

I am on a PR to add a coverage benchmark to pyperformance to aid benchmarking. (python/pyperformance#213)

@kumaraditya303
Copy link

This results in a 20% speedup on main branch vs this branch:

Benchmark 3.12 PyCode_GetCode
coverage 204 ms 170 ms: 1.20x faster

Benchmark: python/pyperformance#213

@nedbat
Copy link
Owner

nedbat commented Jun 6, 2022

This looks like a slight improvement. Not the 20% that @kumaraditya303 found, but worthwhile:

pyver proj 6.4.1 #1394 #1394 vs 6.4.1
python3.11 bug1339.py 0.828 s 0.807 s 97%
python3.11 bm_sudoku.py 55.887 s 52.904 s 94%
python3.11 bm_spectral_norm.py 68.005 s 61.789 s 90%

benchmark: d71d74e

nedbat added a commit that referenced this pull request Jun 6, 2022
@nedbat nedbat merged commit 6b67078 into nedbat:master Jun 6, 2022
@sweeneyde sweeneyde deleted the patch-1 branch June 7, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants