-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage benchmark #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing something about this.
Question for @kumaraditya303 -- Have you actually tried this before and after the regression you mentioned as example?
Question for @ericsnowcurrently -- Do you agree this is useful?
@gvanrossum: The regression I linked above 1 is not caused by a single change but rather accumulation of multiple slowdown caused by multiple changes of which the most significant ones being python/cpython#91666 and python/cpython#27077. Since there is no benchmark in pyperformance to exercise coverage performance, the slowdown was unnoticed. Once this benchmark is added, it will help us pinpoint which commits caused the most slowdown with a simple Footnotes |
Nevertheless it would be interesting to see the numbers of running this BM on the state before and after said commits to demonstrate its usefulness. |
I am running the benchmarks now, will post soon. |
@gvanrossum Benchmarking before and after python/cpython@944fffe commit Results:
|
Yeah, it's a helpful indicator of impact. |
Add a coverage benchmark to help benchmarking and avoid regressions such as python/cpython#93516.
Benchmark result 3.10 vs 3.12 main branch.