Put contexts dict in <script> and reveal them using JavaScript #1587

abo-abo · 2023-03-16T18:12:55Z

Fixes #1584.
The overall size of the generated HTML files has shrunk from 1.5G to 257M.
The size of the largest file down from 196M down to 9.2M.
All files are manageable now with <1s load time in the browser. And maybe 1s reveal time via JavaScript in case of 5k contexts.

nedbat · 2023-03-17T14:51:50Z

coverage/html.py

@@ -367,6 +369,11 @@ def write_html_file(self, ftr: FileToReport, prev_html: str, next_html: str) ->

        # Write the HTML page for this file.
        file_data = self.datagen.data_for_file(ftr.fr, ftr.analysis)
+
+        contexts=Counter(c for cline in file_data.lines for c in cline.contexts)


Suprisingly, my linters don't complain about the lack of spaces around the = here...

nedbat · 2023-03-17T14:52:47Z

coverage/html.py

@@ -380,6 +387,8 @@ def write_html_file(self, ftr: FileToReport, prev_html: str, next_html: str) ->
                    )
            ldata.html = ''.join(html_parts)

+            ldata.context_str = ",".join([str(context_codes[c_context]) for c_context in ldata.context_list])


nit: you don't need the list comprehension inside the join, you can just remove the square brackets.

nedbat · 2023-03-17T14:53:35Z

coverage/html.py

@@ -412,9 +421,14 @@ def write_html_file(self, ftr: FileToReport, prev_html: str, next_html: str) ->
                )
            ldata.css_class = ' '.join(css_classes) or "pln"

+        di = file_data.__dict__
+        if contexts_json == "{}":
+            di["contexts_json"] = None


Wouldn't it just be easier to use:

file_data["contexts_json"] = None

and then not have to create the di variable?

nedbat · 2023-03-17T14:54:40Z

coverage/html.py

@@ -412,9 +421,14 @@ def write_html_file(self, ftr: FileToReport, prev_html: str, next_html: str) ->
                )
            ldata.css_class = ' '.join(css_classes) or "pln"

+        di = file_data.__dict__
+        if contexts_json == "{}":


It feels a little odd to check for no contexts like this. Can we use if not contexts: instead?

nedbat · 2023-03-17T14:55:19Z

coverage/htmlfiles/coverage_html.js

Please note that I use four-space indents in .js and .html files. I recommend an editorconfig plugin for your editor to adjust settings automatically.

nedbat · 2023-03-17T14:56:59Z

coverage/htmlfiles/coverage_html.js

+  cboxes = document.querySelectorAll('[id^=ctxs]')
+  cboxes.forEach(function(cbox) {
+    cbox.addEventListener("click", coverage.showContexts)
+  });


Maybe this code should be inside pyfile_ready, since it only applies to those files?

nedbat · 2023-03-17T14:57:27Z

coverage/htmlfiles/coverage_html.js

+    span_text.split(",").forEach(function(s) {
+      ctx = contexts[s];
+      span.appendChild(document.createTextNode(ctx));
+      span.appendChild(document.createElement("br"));


This creates slightly different HTML than the current code, so the styling needs to be adjusted to keep the right-alignment.

nedbat

Thanks so much for doing this. There are other linting errors to address also.

nedbat · 2023-03-17T15:01:57Z

Now I'm wondering about fancier over-engineered more compact encodings of the contexts, but that can wait (perhaps until never).

abo-abo · 2023-03-17T15:50:55Z

Hi. Thanks for the review. I've addressed the review comments. Even the CSS one somehow. Please check if it's fine: I'm not a frontend guy so I just googled.

nedbat · 2023-03-17T16:10:11Z

coverage/htmlfiles/style.css

@@ -258,7 +258,7 @@ kbd { border: 1px solid black; border-color: #888 #333 #333 #888; padding: .1em

 @media (prefers-color-scheme: dark) { #source p label.ctx { color: #777; } }

-#source p .ctxs { display: block; max-height: 0; overflow-y: hidden; transition: all .2s; padding: 0 .5em; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; white-space: nowrap; background: #d0e8ff; border-radius: .25em; margin-right: 1.75em; }
+#source p .ctxs { display: block; max-height: 0; overflow-y: hidden; transition: all .2s; padding: 0 .5em; font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; white-space: nowrap; background: #d0e8ff; border-radius: .25em; margin-right: 1.75em; text-align: right; }


This file is generated from a .scss file. You want to add this setting in place of the span clause here: https://github.com/nedbat/coveragepy/blob/master/coverage/htmlfiles/style.scss#L625-L628

nedbat · 2023-03-17T16:11:44Z

I'm surprised you didn't need to update any tests. That tells me that I had no tests of HTML output with contexts!? Yikes. I can provide one later.

nedbat · 2023-03-17T16:12:57Z

The test failures are because the CSS file has changed. I can help get those tests passing once you move the setting to the .scss file.

abo-abo · 2023-03-20T15:50:21Z

Hi. I've fixed the tests except tox lint. That seems to fail unrelated to the PR?

nedbat · 2023-03-20T16:01:39Z

The lint failures are in your changes in html.py:

coverage/html.py:390 C: Line too long (107/100) (line-too-long)
coverage/html.py:13 W: Reimport 'json' (imported line 9) (reimported)
coverage/html.py:13 C: Imports from package json are not grouped (ungrouped-imports)

Also, the mypy failure:

coverage/html.py:390: error: "LineData" has no attribute "context_str"; maybe "context_list" or "contexts"?  [attr-defined]

abo-abo · 2023-03-20T20:07:05Z

Ah, I see it now. Github actions has helpfully hidden the lint results like this:

> tox:lint
... weird exit code...

So I had to click on > tox:lint to see the lint erorrs. Thanks for pointing this out!

nedbat · 2023-03-21T13:13:29Z

I added a test to the master branch that should fail here because the context HTML is different. We can update the gold files on this branch to make them pass.

nedbat · 2023-03-21T15:17:44Z

To fix the test failures now, you should be able to cd into tests/gold/html, and run make update-gold.

Fixes nedbat#1584

nedbat · 2023-04-01T13:09:47Z

BTW, in b8498bf I made the shortcodes more compact. It shaved another 5% off the size of my contextful HTML reports.

nedbat · 2023-04-06T14:38:40Z

This is now released as part of coverage 7.2.3.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [coverage](https://togithub.com/nedbat/coveragepy) | `==7.2.2` -> `==7.2.3` | [![age](https://badges.renovateapi.com/packages/pypi/coverage/7.2.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/coverage/7.2.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/coverage/7.2.3/compatibility-slim/7.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/coverage/7.2.3/confidence-slim/7.2.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nedbat/coveragepy</summary> ### [`v7.2.3`](https://togithub.com/nedbat/coveragepy/blob/HEAD/CHANGES.rst#Version-723--2023-04-06) [Compare Source](https://togithub.com/nedbat/coveragepy/compare/7.2.2...7.2.3) - Fix: the :ref:`config_run_sigterm` setting was meant to capture data if a process was terminated with a SIGTERM signal, but it didn't always. This was fixed thanks to `Lewis Gaul <pull 1600_>`*, closing `issue 1599`*. - Performance: HTML reports with context information are now much more compact. File sizes are typically as small as one-third the previous size, but can be dramatically smaller. This closes `issue 1584`\_ thanks to `Oleh Krehel <pull 1587_>`\_. - Development dependencies no longer use hashed pins, closing `issue 1592`\_. .. \_issue 1584:[https://github.com/nedbat/coveragepy/issues/1584](https://togithub.com/nedbat/coveragepy/issues/1584)4 .. \_pull 1587[https://github.com/nedbat/coveragepy/pull/1587](https://togithub.com/nedbat/coveragepy/pull/1587)87 .. \_issue 159[https://github.com/nedbat/coveragepy/issues/1592](https://togithub.com/nedbat/coveragepy/issues/1592)592 .. \_issue 15[https://github.com/nedbat/coveragepy/issues/1599](https://togithub.com/nedbat/coveragepy/issues/1599)1599 .. \_pull 1[https://github.com/nedbat/coveragepy/pull/1600](https://togithub.com/nedbat/coveragepy/pull/1600)/1600 .. \_changes\_7-2-2: </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Version 7.2.5 — 2023-04-30 -------------------------- - Fix: ``html_report()`` could fail with an AttributeError on ``isatty`` if run in an unusual environment where sys.stdout had been replaced. This is now fixed. Version 7.2.4 — 2023-04-28 -------------------------- PyCon 2023 sprint fixes! - Fix: with ``relative_files = true``, specifying a specific file to include or omit wouldn't work correctly (`issue 1604`_). This is now fixed, with testing help by `Marc Gibbons <pull 1608_>`_. - Fix: the XML report would have an incorrect ``<source>`` element when using relative files and the source option ended with a slash (`issue 1541`_). This is now fixed, thanks to `Kevin Brown-Silva <pull 1608_>`_. - When the HTML report location is printed to the terminal, it's now a terminal-compatible URL, so that you can click the location to open the HTML file in your browser. Finishes `issue 1523`_ thanks to `Ricardo Newbery <pull 1613_>`_. - Docs: a new :ref:`Migrating page <migrating>` with details about how to migrate between major versions of coverage.py. It currently covers the wildcard changes in 7.x. Thanks, `Brian Grohe <pull 1610_>`_. .. _issue 1523: nedbat/coveragepy#1523 .. _issue 1541: nedbat/coveragepy#1541 .. _issue 1604: nedbat/coveragepy#1604 .. _pull 1608: nedbat/coveragepy#1608 .. _pull 1609: nedbat/coveragepy#1609 .. _pull 1610: nedbat/coveragepy#1610 .. _pull 1613: nedbat/coveragepy#1613 Version 7.2.3 — 2023-04-06 -------------------------- - Fix: the :ref:`config_run_sigterm` setting was meant to capture data if a process was terminated with a SIGTERM signal, but it didn't always. This was fixed thanks to `Lewis Gaul <pull 1600_>`_, closing `issue 1599`_. - Performance: HTML reports with context information are now much more compact. File sizes are typically as small as one-third the previous size, but can be dramatically smaller. This closes `issue 1584`_ thanks to `Oleh Krehel <pull 1587_>`_. - Development dependencies no longer use hashed pins, closing `issue 1592`_. .. _issue 1584: nedbat/coveragepy#1584 .. _pull 1587: nedbat/coveragepy#1587 .. _issue 1592: nedbat/coveragepy#1592 .. _issue 1599: nedbat/coveragepy#1599 .. _pull 1600: nedbat/coveragepy#1600 Version 7.2.2 — 2023-03-16 -------------------------- - Fix: if a virtualenv was created inside a source directory, and a sourced package was installed inside the virtualenv, then all of the third-party packages inside the virtualenv would be measured. This was incorrect, but has now been fixed: only the specified packages will be measured, thanks to `Manuel Jacob <pull 1560_>`_. - Fix: the ``coverage lcov`` command could create a .lcov file with incorrect LF (lines found) and LH (lines hit) totals. This is now fixed, thanks to `Ian Moore <pull 1583_>`_. - Fix: the ``coverage xml`` command on Windows could create a .xml file with duplicate ``<package>`` elements. This is now fixed, thanks to `Benjamin Parzella <pull 1574_>`_, closing `issue 1573`_. .. _pull 1560: nedbat/coveragepy#1560 .. _issue 1573: nedbat/coveragepy#1573 .. _pull 1574: nedbat/coveragepy#1574 .. _pull 1583: nedbat/coveragepy#1583 Version 7.2.1 — 2023-02-26 -------------------------- - Fix: the PyPI page had broken links to documentation pages, but no longer does, closing `issue 1566`_. - Fix: public members of the coverage module are now properly indicated so that mypy will find them, fixing `issue 1564`_. .. _issue 1564: nedbat/coveragepy#1564 .. _issue 1566: nedbat/coveragepy#1566 Version 7.2.0 — 2023-02-22 -------------------------- - Added a new setting ``[report] exclude_also`` to let you add more exclusions without overwriting the defaults. Thanks, `Alpha Chen <pull 1557_>`_, closing `issue 1391`_. - Added a :meth:`.CoverageData.purge_files` method to remove recorded data for a particular file. Contributed by `Stephan Deibel <pull 1547_>`_. - Fix: when reporting commands fail, they will no longer congratulate themselves with messages like "Wrote XML report to file.xml" before spewing a traceback about their failure. - Fix: arguments in the public API that name file paths now accept pathlib.Path objects. This includes the ``data_file`` and ``config_file`` arguments to the Coverage constructor and the ``basename`` argument to CoverageData. Closes `issue 1552`_. - Fix: In some embedded environments, an IndexError could occur on stop() when the originating thread exits before completion. This is now fixed, thanks to `Russell Keith-Magee <pull 1543_>`_, closing `issue 1542`_. - Added a ``py.typed`` file to announce our type-hintedness. Thanks, `KotlinIsland <pull 1550_>`_. .. _issue 1391: nedbat/coveragepy#1391 .. _issue 1542: nedbat/coveragepy#1542 .. _pull 1543: nedbat/coveragepy#1543 .. _pull 1547: nedbat/coveragepy#1547 .. _pull 1550: nedbat/coveragepy#1550 .. _issue 1552: nedbat/coveragepy#1552 .. _pull 1557: nedbat/coveragepy#1557 Version 7.1.0 — 2023-01-24 -------------------------- - Added: the debug output file can now be specified with ``[run] debug_file`` in the configuration file. Closes `issue 1319`_. - Performance: fixed a slowdown with dynamic contexts that's been around since 6.4.3. The fix closes `issue 1538`_. Thankfully this doesn't break the `Cython change`_ that fixed `issue 972`_. Thanks to Mathieu Kniewallner for the deep investigative work and comprehensive issue report. - Typing: all product and test code has type annotations. .. _Cython change: nedbat/coveragepy#1347 .. _issue 972: nedbat/coveragepy#972 .. _issue 1319: nedbat/coveragepy#1319 .. _issue 1538: nedbat/coveragepy#1538 Version 7.0.5 — 2023-01-10 -------------------------- - Fix: On Python 3.7, a file with type annotations but no ``from __future__ import annotations`` would be missing statements in the coverage report. This is now fixed, closing `issue 1524`_. .. _issue 1524: nedbat/coveragepy#1524 Version 7.0.4 — 2023-01-07 -------------------------- - Performance: an internal cache of file names was accidentally disabled, resulting in sometimes drastic reductions in performance. This is now fixed, closing `issue 1527`_. Thanks to Ivan Ciuvalschii for the reproducible test case. .. _issue 1527: nedbat/coveragepy#1527 Version 7.0.3 — 2023-01-03 -------------------------- - Fix: when using pytest-cov or pytest-xdist, or perhaps both, the combining step could fail with ``assert row is not None`` using 7.0.2. This was due to a race condition that has always been possible and is still possible. In 7.0.1 and before, the error was silently swallowed by the combining code. Now it will produce a message "Couldn't combine data file" and ignore the data file as it used to do before 7.0.2. Closes `issue 1522`_. .. _issue 1522: nedbat/coveragepy#1522 Version 7.0.2 — 2023-01-02 -------------------------- - Fix: when using the ``[run] relative_files = True`` setting, a relative ``[paths]`` pattern was still being made absolute. This is now fixed, closing `issue 1519`_. - Fix: if Python doesn't provide tomllib, then TOML configuration files can only be read if coverage.py is installed with the ``[toml]`` extra. Coverage.py will raise an error if TOML support is not installed when it sees your settings are in a .toml file. But it didn't understand that ``[tools.coverage]`` was a valid section header, so the error wasn't reported if you used that header, and settings were silently ignored. This is now fixed, closing `issue 1516`_. - Fix: adjusted how decorators are traced on PyPy 7.3.10, fixing `issue 1515`_. - Fix: the ``coverage lcov`` report did not properly implement the ``--fail-under=MIN`` option. This has been fixed. - Refactor: added many type annotations, including a number of refactorings. This should not affect outward behavior, but they were a bit invasive in some places, so keep your eyes peeled for oddities. - Refactor: removed the vestigial and long untested support for Jython and IronPython. .. _issue 1515: nedbat/coveragepy#1515 .. _issue 1516: nedbat/coveragepy#1516 .. _issue 1519: nedbat/coveragepy#1519 Version 7.0.1 — 2022-12-23 -------------------------- - When checking if a file mapping resolved to a file that exists, we weren't considering files in .whl files. This is now fixed, closing `issue 1511`_. - File pattern rules were too strict, forbidding plus signs and curly braces in directory and file names. This is now fixed, closing `issue 1513`_. - Unusual Unicode or control characters in source files could prevent reporting. This is now fixed, closing `issue 1512`_. - The PyPy wheel now installs on PyPy 3.7, 3.8, and 3.9, closing `issue 1510`_. .. _issue 1510: nedbat/coveragepy#1510 .. _issue 1511: nedbat/coveragepy#1511 .. _issue 1512: nedbat/coveragepy#1512 .. _issue 1513: nedbat/coveragepy#1513 Version 7.0.0 — 2022-12-18 -------------------------- Nothing new beyond 7.0.0b1. Version 7.0.0b1 — 2022-12-03 ---------------------------- A number of changes have been made to file path handling, including pattern matching and path remapping with the ``[paths]`` setting (see :ref:`config_paths`). These changes might affect you, and require you to update your settings. (This release includes the changes from `6.6.0b1 <changes_6-6-0b1_>`_, since 6.6.0 was never released.) - Changes to file pattern matching, which might require updating your configuration: - Previously, ``*`` would incorrectly match directory separators, making precise matching difficult. This is now fixed, closing `issue 1407`_. - Now ``**`` matches any number of nested directories, including none. - Improvements to combining data files when using the :ref:`config_run_relative_files` setting, which might require updating your configuration: - During ``coverage combine``, relative file paths are implicitly combined without needing a ``[paths]`` configuration setting. This also fixed `issue 991`_. - A ``[paths]`` setting like ``*/foo`` will now match ``foo/bar.py`` so that relative file paths can be combined more easily. - The :ref:`config_run_relative_files` setting is properly interpreted in more places, fixing `issue 1280`_. - When remapping file paths with ``[paths]``, a path will be remapped only if the resulting path exists. The documentation has long said the prefix had to exist, but it was never enforced. This fixes `issue 608`_, improves `issue 649`_, and closes `issue 757`_. - Reporting operations now implicitly use the ``[paths]`` setting to remap file paths within a single data file. Combining multiple files still requires the ``coverage combine`` step, but this simplifies some single-file situations. Closes `issue 1212`_ and `issue 713`_. - The ``coverage report`` command now has a ``--format=`` option. The original style is now ``--format=text``, and is the default. - Using ``--format=markdown`` will write the table in Markdown format, thanks to `Steve Oswald <pull 1479_>`_, closing `issue 1418`_. - Using ``--format=total`` will write a single total number to the output. This can be useful for making badges or writing status updates. - Combining data files with ``coverage combine`` now hashes the data files to skip files that add no new information. This can reduce the time needed. Many details affect the speed-up, but for coverage.py's own test suite, combining is about 40% faster. Closes `issue 1483`_. - When searching for completely un-executed files, coverage.py uses the presence of ``__init__.py`` files to determine which directories have source that could have been imported. However, `implicit namespace packages`_ don't require ``__init__.py``. A new setting ``[report] include_namespace_packages`` tells coverage.py to consider these directories during reporting. Thanks to `Felix Horvat <pull 1387_>`_ for the contribution. Closes `issue 1383`_ and `issue 1024`_. - Fixed environment variable expansion in pyproject.toml files. It was overly broad, causing errors outside of coverage.py settings, as described in `issue 1481`_ and `issue 1345`_. This is now fixed, but in rare cases will require changing your pyproject.toml to quote non-string values that use environment substitution. - An empty file has a coverage total of 100%, but used to fail with ``--fail-under``. This has been fixed, closing `issue 1470`_. - The text report table no longer writes out two separator lines if there are no files listed in the table. One is plenty. - Fixed a mis-measurement of a strange use of wildcard alternatives in match/case statements, closing `issue 1421`_. - Fixed internal logic that prevented coverage.py from running on implementations other than CPython or PyPy (`issue 1474`_). - The deprecated ``[run] note`` setting has been completely removed. .. _implicit namespace packages: https://peps.python.org/pep-0420/ .. _issue 608: nedbat/coveragepy#608 .. _issue 649: nedbat/coveragepy#649 .. _issue 713: nedbat/coveragepy#713 .. _issue 757: nedbat/coveragepy#757 .. _issue 991: nedbat/coveragepy#991 .. _issue 1024: nedbat/coveragepy#1024 .. _issue 1212: nedbat/coveragepy#1212 .. _issue 1280: nedbat/coveragepy#1280 .. _issue 1345: nedbat/coveragepy#1345 .. _issue 1383: nedbat/coveragepy#1383 .. _issue 1407: nedbat/coveragepy#1407 .. _issue 1418: nedbat/coveragepy#1418 .. _issue 1421: nedbat/coveragepy#1421 .. _issue 1470: nedbat/coveragepy#1470 .. _issue 1474: nedbat/coveragepy#1474 .. _issue 1481: nedbat/coveragepy#1481 .. _issue 1483: nedbat/coveragepy#1483 .. _pull 1387: nedbat/coveragepy#1387 .. _pull 1479: nedbat/coveragepy#1479 Version 6.6.0b1 — 2022-10-31 ---------------------------- (Note: 6.6.0 final was never released. These changes are part of `7.0.0b1 <changes_7-0-0b1_>`_.) - Changes to file pattern matching, which might require updating your configuration: - Previously, ``*`` would incorrectly match directory separators, making precise matching difficult. This is now fixed, closing `issue 1407`_. - Now ``**`` matches any number of nested directories, including none. - Improvements to combining data files when using the :ref:`config_run_relative_files` setting: - During ``coverage combine``, relative file paths are implicitly combined without needing a ``[paths]`` configuration setting. This also fixed `issue 991`_. - A ``[paths]`` setting like ``*/foo`` will now match ``foo/bar.py`` so that relative file paths can be combined more easily. - The setting is properly interpreted in more places, fixing `issue 1280`_. - Fixed environment variable expansion in pyproject.toml files. It was overly broad, causing errors outside of coverage.py settings, as described in `issue 1481`_ and `issue 1345`_. This is now fixed, but in rare cases will require changing your pyproject.toml to quote non-string values that use environment substitution. - Fixed internal logic that prevented coverage.py from running on implementations other than CPython or PyPy (`issue 1474`_). .. _issue 991: nedbat/coveragepy#991 .. _issue 1280: nedbat/coveragepy#1280 .. _issue 1345: nedbat/coveragepy#1345 .. _issue 1407: nedbat/coveragepy#1407 .. _issue 1474: nedbat/coveragepy#1474 .. _issue 1481: nedbat/coveragepy#1481

nedbat reviewed Mar 17, 2023

View reviewed changes

nedbat requested changes Mar 17, 2023

View reviewed changes

nedbat force-pushed the oleh/contexts branch from 30f4353 to 33737dd Compare March 17, 2023 15:02

nedbat reviewed Mar 17, 2023

View reviewed changes

abo-abo force-pushed the oleh/contexts branch from 990bae7 to d0fccc5 Compare March 20, 2023 10:17

abo-abo force-pushed the oleh/contexts branch from aaae8c2 to 53b9967 Compare March 20, 2023 20:05

abo-abo added 6 commits March 22, 2023 12:20

Put contexts dict in <script> and reveal them using JavaScript

6329d31

Fixes nedbat#1584

Address review comments

e550869

coverage/htmlfiles/style.css: Align the contexts to the right

49220af

coverage/htmlfiles/style.scss: Match style.css

9833e3d

coverage/html.py: Fix linting and mypy errors

d2ef5c6

two_tests_py.html: make update-gold

809266c

nedbat force-pushed the oleh/contexts branch from 29b3aff to 809266c Compare March 22, 2023 16:20

nedbat approved these changes Mar 22, 2023

View reviewed changes

nedbat merged commit d6cb1cd into nedbat:master Mar 22, 2023

nedbat added a commit that referenced this pull request Mar 22, 2023

style: clean up #1587

e8cb9fa

nedbat added a commit that referenced this pull request Mar 22, 2023

style: clean up #1587

fb2a978

nedbat added a commit that referenced this pull request Mar 22, 2023

style: clean up #1587

18c0993

nedbat added a commit that referenced this pull request Mar 22, 2023

style: clean up #1587

63f3e49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put contexts dict in <script> and reveal them using JavaScript #1587

Put contexts dict in <script> and reveal them using JavaScript #1587

abo-abo commented Mar 16, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat Mar 17, 2023

nedbat left a comment

nedbat commented Mar 17, 2023

abo-abo commented Mar 17, 2023

nedbat Mar 17, 2023

nedbat commented Mar 17, 2023

nedbat commented Mar 17, 2023

abo-abo commented Mar 20, 2023

nedbat commented Mar 20, 2023

abo-abo commented Mar 20, 2023

nedbat commented Mar 21, 2023

nedbat commented Mar 21, 2023

nedbat commented Apr 1, 2023

nedbat commented Apr 6, 2023

Put contexts dict in <script> and reveal them using JavaScript #1587

Put contexts dict in <script> and reveal them using JavaScript #1587

Conversation

abo-abo commented Mar 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nedbat left a comment

Choose a reason for hiding this comment

nedbat commented Mar 17, 2023

abo-abo commented Mar 17, 2023

Choose a reason for hiding this comment

nedbat commented Mar 17, 2023

nedbat commented Mar 17, 2023

abo-abo commented Mar 20, 2023

nedbat commented Mar 20, 2023

abo-abo commented Mar 20, 2023

nedbat commented Mar 21, 2023

nedbat commented Mar 21, 2023

nedbat commented Apr 1, 2023

nedbat commented Apr 6, 2023