Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

コーディングルールに合わせてディレクトリ名とファイル名をケバブケースに変更 #38

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

kobayashi-m42
Copy link
Member

@kobayashi-m42 kobayashi-m42 commented Aug 1, 2021

issueURL

#39

関連URL

#37 (comment)

Doneの定義

  • ディレクトリ名とファイル名がコーディングスタイルに合っていること

変更点概要

表題の通り。
リソースの再作成は不要。terraform plan で差分がないことを確認している。

@kobayashi-m42 kobayashi-m42 changed the base branch from main to feature/issue13/rds-proxy August 1, 2021 15:13
Base automatically changed from feature/issue13/rds-proxy to main August 2, 2021 09:37
@kobayashi-m42 kobayashi-m42 self-assigned this Aug 2, 2021
@kobayashi-m42 kobayashi-m42 marked this pull request as ready for review August 2, 2021 09:43
@kobayashi-m42 kobayashi-m42 requested a review from keitakn August 2, 2021 09:43
@keitakn keitakn added this to the 11 2021-07-26-2021-08-15 milestone Aug 2, 2021
Copy link
Member

@keitakn keitakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとう🐱
問題ないと思う👌

LGTMeow

@keitakn keitakn removed this from the 11 2021-07-26-2021-08-15 milestone Aug 2, 2021
@kobayashi-m42 kobayashi-m42 merged commit 387096f into main Aug 2, 2021
@kobayashi-m42 kobayashi-m42 deleted the feature/fix-code-style branch August 2, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants