Remove remaining config_settings, now that they're unnecessary and use macOS system libs #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to bazelbuild/bazel#13047 landed in 5.1
Part of the macOS API as with all on all other Apple platforms
Note that unlike libz, bz2 is not bundled with Android
|
...and that caused me to notice that Apple platforms also bundle bz2, so I switched us to using system bz2 on Apple platforms, parallel to zlib. [Note: Unlike libz, bz2 is not bundled with Android. And lzma is bundled with Apple platforms, but sadly, not considered public API because its header is not exposed.] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @nelhage.
This PR follows up on #247 and #245, cleaning out a workaround that is no longer needed with the release of Bazel 5.1.
It also switches things to use system libz on macOS, consistent with all the other Apple platforms. I know the system version has been significantly faster in the past, too.
The two are joined into one PR to avoid conflicts and because you've been open to that in the past.
Thanks for all you do!
Chris