-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for modules #557
Conversation
How does this significantly differ from this earlier PR? I think the main thing it adds is a module rule to select the boost version. Is that right? |
It's been a while since I created this pr, and it was because I needed this module version for one of my projects and the other PR was lacking some features I needed. Mainly the boost version selection, as you noticed, and the ability to force only static boost compilation. I think that the version selection feature can be easily implemented in the other pr, before or after the merge. |
It would be nice to get this project ported over. It's fairly popular and I have a downstream PR which could depend on a port in |
Feel free to close this pr. When you merge the other one I can open another one to add the feature. |
Thanks for your contribution! Moving to Bzlmod was finally performed in #553 If we should overtalk something from this PR pleas open a new PR! |
This is a first draft to add support for the new Module system that is becoming the standard for bazel.
It seems to pass all the tests at least on my machine, but I haven't really tested on different architectures yet.
Doubts
e. g.
com_github_facebook_zstd
->zstd
com_github_nelhage_rules_boost
torules_boost
[ closes #482 ]