Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sierra support #4

Closed
unnamed777 opened this issue Sep 26, 2016 · 12 comments
Closed

Sierra support #4

unnamed777 opened this issue Sep 26, 2016 · 12 comments

Comments

@unnamed777
Copy link

Unfortunately it doesn't work on Sierra. The app returns "res: 0" or "res: 1", but actual fn state isn't changed.

@nelsonjchen
Copy link
Owner

Hmm shoot. This is beyond my expertise. I'll try to take a look though.

On Mon, Sep 26, 2016, 12:39 AM Andrey Neyman notifications@github.com
wrote:

Unfortunately it doesn't work on Sierra. The app returns "res: 0" or "res:
1", but actual fn state isn't changed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAU8_1fjfJ63sN0trpAPHByMUtoe0Hlks5qt3bDgaJpZM4KGORd
.

@nelsonjchen
Copy link
Owner

I think this is a bit beyond me but I'll try to look this weekend. It looks like people doing this sort of thing are getting hit as evidenced by the Karabiner crew. Like anything that touches IOHIDKeyboard or something.

@unnamed777
Copy link
Author

Thanks!
I thought I could replace some Karabiner mappings with hammerspoon + your application.

@nelsonjchen
Copy link
Owner

Odd, this works for me. I'm even using the binary I had uploaded to GitHub for 0.0.2.

@nelsonjchen
Copy link
Owner

That said, what is your setup? It appears to work with the built-in keyboard of a Mid-2012 rMBP.

@unnamed777
Copy link
Author

MBP mid 2014 15"

@nelsonjchen
Copy link
Owner

There might be one at work of similar or newer vintage. I'll check it out.

@unnamed777
Copy link
Author

It turned out Karabiner-Elements interfers with your app even if its config doesn't have Fn mappings. When I quit Karabiner, the app works as it's supposed. Sorry for bothering you.

@nelsonjchen
Copy link
Owner

Not really bothering. Now that might be a TODO to put in the README. I myself am waiting for Elements to get non-Apple keyboard matching bindings to swap Command and WinKey and maybe I would have hit that soon.

@7fe
Copy link

7fe commented Mar 17, 2017

So what is this advantage of not using applescript if it still breaks like this on updates?

@nelsonjchen
Copy link
Owner

This issue wasn't caused by an macOS update. It just couldn't coexist with Karabiner-Elements at that time. It still works fine on Sierra without Karabiner-Elements.

We didn't test it, but I would guess that even the AppleScript approach wouldn't have worked with Karabiner-Elements at that time either. This tool toggles the underlying thing the stock checkbox would toggle. If the underlying thing is modified or bypassed due to things like Karabiner-Elements, AppleScript and/or whatever this is using wouldn't work anyway.

@nelsonjchen
Copy link
Owner

I haven't touched the active ingredients for that portion in this for the past 3 years. Still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants