Skip to content

Commit

Permalink
Merge #1744
Browse files Browse the repository at this point in the history
1744: fix(cypress): more time for website:start:prod to finish in cypress script r=spencercorwin a=spencercorwin

### Description of the Change

Bumps the time from 3 minutes to 5 minutes for the website to startup in the `runCypress` script. 3 minutes wasn't enough time to finish the `website:start:prod` script, thus causing the Cypress tests to fail when run in `--local` mode.

### Test Plan

Run `yarn test:cypress-express --local` locally and see the Cypress express test pass.

### Alternate Designs

None.

### Benefits

Passing tests.

### Possible Drawbacks

None.

### Applicable Issues

#1740 

Co-authored-by: Spencer Corwin <spencercorwin@icloud.com>
  • Loading branch information
bors[bot] and spencercorwin authored Sep 5, 2019
2 parents 33349ca + 05b0058 commit 74f8d9a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/website/runCypress.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ const run = async () => {
});

const TEN_MINUTES = 10 * 60 * 1000;
const THREE_MINUTES = 3 * 60 * 1000;
await timer(argv.local ? THREE_MINUTES : TEN_MINUTES).toPromise();
const FIVE_MINUTES = 5 * 60 * 1000;
await timer(argv.local ? FIVE_MINUTES : TEN_MINUTES).toPromise();
await runCypress();
};

Expand Down

0 comments on commit 74f8d9a

Please sign in to comment.