fix(cypress): more time for website:start:prod to finish in cypress script #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 5, 2019
1744: fix(cypress): more time for website:start:prod to finish in cypress script r=spencercorwin a=spencercorwin ### Description of the Change Bumps the time from 3 minutes to 5 minutes for the website to startup in the `runCypress` script. 3 minutes wasn't enough time to finish the `website:start:prod` script, thus causing the Cypress tests to fail when run in `--local` mode. ### Test Plan Run `yarn test:cypress-express --local` locally and see the Cypress express test pass. ### Alternate Designs None. ### Benefits Passing tests. ### Possible Drawbacks None. ### Applicable Issues #1740 Co-authored-by: Spencer Corwin <spencercorwin@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bumps the time from 3 minutes to 5 minutes for the website to startup in the
runCypressscript. 3 minutes wasn't enough time to finish thewebsite:start:prodscript, thus causing the Cypress tests to fail when run in--localmode.Test Plan
Run
yarn test:cypress-express --locallocally and see the Cypress express test pass.Alternate Designs
None.
Benefits
Passing tests.
Possible Drawbacks
None.
Applicable Issues
#1740