Allow traverse iterators #715
Conversation
|
This is certainly a better approach than I sketched out with #708. One thing I got to thinking about while I was sketching #708: Should we consider exposing some RPC methods via WebSockets and/or SignalR? WebSockets would be a better model for exposing iterators that anything that runs over HTTP. Plus we could implement callback style operations like "notify me for every new block" and "submit this transaction and wait for it to be included in a block" with reasonable efficiency. Obviously, such an approach should be a separate PR if we decide to go this route. I opened #716 to discuss |
NeoGo provides that along with event subscription mechanism. |
# Conflicts: # src/RpcServer/RpcServer.SmartContract.cs
|
Do we need to update the RpcClient? |
Yes. It would be nice to expose Iterators in RpcClient via IAsyncEnumerable. But I personally don't have an issue doing that as a separate PR |
| [RpcMethod] | ||
| protected virtual JObject InvokeFunction(JArray _params) | ||
| { | ||
| UInt160 script_hash = UInt160.Parse(_params[0].AsString()); | ||
| string operation = _params[1].AsString(); | ||
| ContractParameter[] args = _params.Count >= 3 ? ((JArray)_params[2]).Select(p => ContractParameter.FromJson(p)).ToArray() : System.Array.Empty<ContractParameter>(); | ||
| Signers signers = _params.Count >= 4 ? SignersFromJson((JArray)_params[3], system.Settings) : null; | ||
| Signer[] signers = _params.Count >= 4 ? SignersFromJson((JArray)_params[3], system.Settings) : null; | ||
| Witness[] witnesses = _params.Count >= 4 ? WitnessesFromJson((JArray)_params[3]) : null; |
There was a problem hiding this comment.
Saved in the same _params as signers? (_params[3])
| Guid id = Guid.NewGuid(); | ||
| session.Iterators.Add(id, iterator); | ||
| json["id"] = id.ToString(); |
There was a problem hiding this comment.
The resulting JSON contains id for each iterator even if sessions are disabled. Is it the desired behaviour?
|
Tested OK with #721. |
Close neo-project/neo#2699