-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rpc Client iterators #721
Merged
erikzhang
merged 13 commits into
neo-project:traverse-iterator
from
Ashuaidehao:rpcclient-iterators
Jun 23, 2022
Merged
Rpc Client iterators #721
erikzhang
merged 13 commits into
neo-project:traverse-iterator
from
Ashuaidehao:rpcclient-iterators
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Jun 4, 2022
Ashuaidehao
force-pushed
the
rpcclient-iterators
branch
from
June 4, 2022 14:45
08b1783
to
521ca8e
Compare
Tested OK. |
Why force push? |
erikzhang
force-pushed
the
rpcclient-iterators
branch
from
June 7, 2022 02:05
521ca8e
to
d935e08
Compare
erikzhang
reviewed
Jun 7, 2022
shargon
reviewed
Jun 8, 2022
shargon
reviewed
Jun 10, 2022
13 tasks
erikzhang
reviewed
Jun 14, 2022
Tested OK. |
superboyiii
approved these changes
Jun 14, 2022
ProDog
approved these changes
Jun 15, 2022
shargon
reviewed
Jun 15, 2022
@@ -157,6 +157,7 @@ private static JObject ToJson(StackItem item, Session session) | |||
{ | |||
Guid id = Guid.NewGuid(); | |||
session.Iterators.Add(id, iterator); | |||
json["interface"] = nameof(IIterator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use "Iterator" instead of "IIterator"?
AnnaShaleva
reviewed
Jun 15, 2022
5 tasks
erikzhang
reviewed
Jun 22, 2022
ProDog
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate #715