Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc Client iterators #721

Merged

Conversation

Ashuaidehao
Copy link
Contributor

Relate #715

@ProDog
Copy link
Contributor

ProDog commented Jun 6, 2022

Tested OK.

@erikzhang
Copy link
Member

Why force push?

src/RpcClient/Utility.cs Outdated Show resolved Hide resolved
@ProDog
Copy link
Contributor

ProDog commented Jun 14, 2022

Tested OK.

@ProDog ProDog self-requested a review June 15, 2022 03:10
@@ -157,6 +157,7 @@ private static JObject ToJson(StackItem item, Session session)
{
Guid id = Guid.NewGuid();
session.Iterators.Add(id, iterator);
json["interface"] = nameof(IIterator);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "Iterator" instead of "IIterator"?

@ProDog ProDog self-requested a review June 23, 2022 10:36
@erikzhang erikzhang merged commit 5dfbdcc into neo-project:traverse-iterator Jun 23, 2022
@ProDog ProDog mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants