Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"NotValidBefore" transaction attribute type #1992

Closed
roman-khimov opened this issue Oct 7, 2020 · 4 comments · Fixed by #2812
Closed

"NotValidBefore" transaction attribute type #1992

roman-khimov opened this issue Oct 7, 2020 · 4 comments · Fixed by #2812
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@roman-khimov
Copy link
Contributor

Do you have any solution you want to propose?
This attribute makes transaction invalid before certain height. It has uint32 data inside which is the block height starting from which the transaction is considered to be valid. It can be seen as the opposite of ValidUntilBlock, using both allows to have a window of valid block numbers that this transaction could be accepted into. Transactions with this attribute are not accepted into mempool before specified block is persisted.

It can be used to create some transactions in advance with a guarantee that they won't be accepted until specified block, that property will be used for signature collection service (#1573).

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • Ledger
  • P2P (TCP)
@roman-khimov roman-khimov added the Discussion Initial issue state - proposed but not yet accepted label Oct 7, 2020
@roman-khimov roman-khimov mentioned this issue Oct 7, 2020
Open
@roman-khimov roman-khimov mentioned this issue Oct 14, 2020
Closed
@roman-khimov
Copy link
Contributor Author

A prototype of that is implemented in nspcc-dev/neo-go#1496, it's quite simple attribute.

@erikzhang
Copy link
Member

Nodes are not obliged to keep transactions that cannot be verified immediately in the memory pool.

@roman-khimov
Copy link
Contributor Author

And they won't keep them, an ordinary node receiving transaction with NVB height more than the current height just drops it as invalid.

@roman-khimov roman-khimov mentioned this issue Apr 11, 2021
Closed
@roman-khimov roman-khimov mentioned this issue Feb 25, 2022
Open
@roman-khimov roman-khimov mentioned this issue Aug 8, 2022
Open
@roman-khimov roman-khimov mentioned this issue Sep 9, 2022
Closed
roman-khimov added a commit to roman-khimov/neo that referenced this issue Sep 13, 2022
@roman-khimov
Payloads: add NotValidBefore transaction attribute
fdc3934 
Fixes neo-project#1992.
@roman-khimov roman-khimov mentioned this issue Sep 13, 2022
Merged
@vncoelho
Copy link
Member

vncoelho commented Mar 8, 2023 •
edited
Loading

Is this closed because of completed?

shargon pushed a commit that referenced this issue Mar 11, 2023
@roman-khimov @erikzhang @vncoelho
Payloads: add NotValidBefore transaction attribute (#2812)
ec7ac2b 
Fixes #1992.

Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
@roman-khimov roman-khimov mentioned this issue Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Payloads: add NotValidBefore transaction attribute roman-khimov/neo
3 participants
@erikzhang @vncoelho @roman-khimov