Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: implement NotValidBefore and Reserved tx attributes #1496

Merged
merged 5 commits into from
Oct 23, 2020
Merged

core: implement NotValidBefore and Reserved tx attributes #1496

merged 5 commits into from
Oct 23, 2020

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Oct 16, 2020 •
edited
Loading

Closes #1490

fyrchik
fyrchik reviewed Oct 19, 2020
View reviewed changes
pkg/core/blockchain.go Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/mempool/mem_pool.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the signatures-collection branch 4 times, most recently from 1979128 to ad6d73c Compare October 20, 2020 15:31
@codecov
Copy link

codecov bot commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #1496 into master will increase coverage by 0.05%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   77.43%   77.49%   +0.05%     
==========================================
  Files         227      229       +2     
  Lines       17716    17753      +37     
==========================================
+ Hits        13719    13757      +38     
+ Misses       3054     3053       -1     
  Partials      943      943
Impacted Files Coverage Δ
pkg/core/transaction/attrtype.go 100.00% <ø> (ø)
pkg/core/transaction/attrtype_string.go 69.23% <66.66%> (+19.23%) ⬆️
pkg/core/transaction/reserved.go 66.66% <66.66%> (ø)
pkg/core/blockchain.go 74.17% <100.00%> (+0.28%) ⬆️
pkg/core/transaction/attribute.go 86.95% <100.00%> (+13.42%) ⬆️
pkg/core/transaction/not_valid_before.go 100.00% <100.00%> (ø)
pkg/core/transaction/transaction.go 88.38% <100.00%> (+0.30%) ⬆️
pkg/rpc/client/wsclient.go 81.20% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a8e95...7947e99. Read the comment docs.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review October 20, 2020 15:41
roman-khimov
roman-khimov requested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this, moving Conflicts to PR of its own? It's the most problematic and it really deserves a bit more attention, while the rest of this is almost fine.

pkg/core/transaction/attrtype.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
pkg/core/mempool/mem_pool.go Outdated Show resolved Hide resolved
pkg/core/transaction/attrtype.go Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva changed the title core: implement NotValidBefore, Reserved and Conflicts tx attributes core: implement NotValidBefore and Reserved tx attributes Oct 23, 2020
@AnnaShaleva AnnaShaleva force-pushed the signatures-collection branch 2 times, most recently from 5fd2bd1 to ad19317 Compare October 23, 2020 07:54
@AnnaShaleva
core: reserve attributes range for experimantal purposes
09b8b8d
@AnnaShaleva
core: refactor transaction.Attribute unmarshalling
a6579a0
@AnnaShaleva
core: verify transaction attributes before adding it into mempool
95630b7 
Attributes check should be done before adding transaction to
the pool, otherwise there might be a case when transaction with invalid
attributes is in the pool.
@AnnaShaleva
core: add transaction.GetAttributes
7947e99
@roman-khimov roman-khimov merged commit 1956f2c into master Oct 23, 2020
@roman-khimov roman-khimov deleted the signatures-collection branch October 23, 2020 08:26
This was referenced Oct 23, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@fyrchik fyrchik Awaiting requested review from fyrchik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "NotValidBefore" transaction attribute
3 participants
@AnnaShaleva @fyrchik @roman-khimov