Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate committee every 28 blocks #1907

Merged
merged 9 commits into from
Sep 11, 2020
Merged

Recalculate committee every 28 blocks #1907

merged 9 commits into from
Sep 11, 2020

Conversation

Qiao-Jin
Copy link
Contributor

@Qiao-Jin Qiao-Jin commented Sep 4, 2020

This PR changes committee/validator calculation from every block to every 28 blocks to realize this comment in #1848

In this PR I assume that ProtocolSettings.Default.ValidatorsCount does not change. Please correct me if I'm wrong.

@shargon
Copy link
Member

shargon commented Sep 4, 2020

In this PR I assume that ProtocolSettings.Default.ValidatorsCount does not change. Please correct me if I'm wrong.

Right, It should never change, it's defined in the protocol, not in the policy.

@shargon shargon mentioned this pull request Sep 4, 2020
Merged
@cloud8little
Copy link
Contributor

@Qiao-Jin can you solve the conflict?

@Tommo-L Tommo-L mentioned this pull request Sep 7, 2020
Merged
@Qiao-Jin
Copy link
Contributor Author

Qiao-Jin commented Sep 9, 2020 •
edited
Loading

@erikzhang What do you think of this plan?

(1) Recalculate committee every 28 blocks

(2) Distribute committee members' incentive every 28 blocks upon recalculating committee members

(3) Distribute voters incentive every 28 blocks upon recalculating committee members

(4) Distribute neo holders incentive every block

@erikzhang
Copy link
Member

Distribute committee members' incentive every 28 blocks upon recalculating committee members

I think the load of distributing incentive should be apportioned to each block.

@Qiao-Jin
Copy link
Contributor Author

Qiao-Jin commented Sep 9, 2020

Distribute committee members' incentive every 28 blocks upon recalculating committee members

I think the load of distributing incentive should be apportioned to each block.

As long as committee members don't change durign the 28 blocks I think both is OK

@erikzhang
Copy link
Member

Conflicts.

@Qiao-Jin
Copy link
Contributor Author

Conflicts.

Have resolved

@erikzhang erikzhang merged commit 8da92c8 into neo-project:master Sep 11, 2020
@Tommo-L Tommo-L mentioned this pull request Sep 11, 2020
Closed
@cloud8little cloud8little mentioned this pull request Sep 11, 2020
Closed
@superboyiii superboyiii mentioned this pull request Sep 15, 2020
Closed
44 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Qiao-Jin
Recalculate committee every 28 blocks (neo-project#1907)
36eb9ca
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Qiao-Jin @cloud8little
Recalculate committee every 28 blocks (neo-project#1907)
73d10c0
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
@ixje
https://github.com/neo-project/neo/pull/1907
03cc285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

@erikzhang erikzhang erikzhang approved these changes

@Tommo-L Tommo-L Tommo-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Qiao-Jin @shargon @cloud8little @erikzhang @Tommo-L