Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize consensus messages (V2.0) #1979

Closed

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 30, 2020

Alternative to #1971
Related to #1971 (comment)

Send only the invocation script with ConsensusPayload

@shargon
Copy link
Member Author

shargon commented Nov 14, 2020

I think that this version it's better than #1971 For me we can save a lot of bytes with the verification scripts around the consensus, so p2p will be improved, less bytes without compression always it's better.

Could you give me your impressions @erikzhang ?

@erikzhang
Copy link
Member

I think saving 35 bytes does not bring much optimization to the network.

@shargon
Copy link
Member Author

shargon commented Nov 16, 2020

I think saving 35 bytes does not bring much optimization to the network.

But it's (35 bytes * 7 consensus nodes) * 3 consensus phases or more, without any cost.

@roman-khimov
Copy link
Contributor

Yeah, to me the main thing is that there is zero cost to doing this. Sure, the effect would probably not be noticeable, but still, why do we transmit things we can not transmit? It's +36 −43 patch, it can't be bad.

@shargon
Copy link
Member Author

shargon commented Jan 29, 2021

It should be done in neo-modules, I think that it's a good solution to speed up p2p protocol, if we decide to use it, I can copy the code to neo-modules.

@shargon shargon closed this Jan 29, 2021
@shargon shargon deleted the optimize-consensus-payload-v2 branch January 29, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants