-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugins to send custom messages #2101
Conversation
Maybe we can merge ConsensusPayload with this payload. This way we can move consensus to plugins too. Then private chains can choose different consensus mechanism. |
Maybe we can do it, when we want to implement dBFT3.0 or other consensus mechanism. |
I think like @Tommo-L , it's a good idea, we can prepare the message for it, but we should do it later |
Also, we can use an optimization like #1979 and send only the |
Moving consensus to plugin is a good direction for simplifying code and open more perspectives. |
src/neo/Ledger/Blockchain.cs
Outdated
GetConsensusAddress(NativeContract.RoleManagement.GetDesignatedByRole(currentSnapshot, Role.Oracle, currentSnapshot.Height)), | ||
GetConsensusAddress(NativeContract.RoleManagement.GetDesignatedByRole(currentSnapshot, Role.StateValidator, currentSnapshot.Height)) | ||
}; | ||
Interlocked.Exchange(ref addressWhiteList, whiteList)?.Clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this code to RoleManagement
contract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so.
Merge? |
Messages must be signed by an authority to avoid misuse of the network
Related to #2079 (comment)