Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to send custom messages #2101

Merged
merged 36 commits into from
Jan 6, 2021
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 25, 2020

Messages must be signed by an authority to avoid misuse of the network

Related to #2079 (comment)

@erikzhang
Copy link
Member

erikzhang commented Nov 26, 2020

Maybe we can merge ConsensusPayload with this payload. This way we can move consensus to plugins too. Then private chains can choose different consensus mechanism.

@Tommo-L
Copy link
Contributor

Tommo-L commented Dec 1, 2020

Maybe we can merge ConsensusPayload with this payload. This way we can move consensus to plugins too. Then private chains can choose different consensus mechanism.

Maybe we can do it, when we want to implement dBFT3.0 or other consensus mechanism.

@shargon
Copy link
Member Author

shargon commented Dec 1, 2020

I think like @Tommo-L , it's a good idea, we can prepare the message for it, but we should do it later

@shargon
Copy link
Member Author

shargon commented Dec 7, 2020

Also, we can use an optimization like #1979 and send only the invocationScript

@vncoelho
Copy link
Member

vncoelho commented Dec 7, 2020

Moving consensus to plugin is a good direction for simplifying code and open more perspectives.
Let's create an issue to leave this pending activity.

GetConsensusAddress(NativeContract.RoleManagement.GetDesignatedByRole(currentSnapshot, Role.Oracle, currentSnapshot.Height)),
GetConsensusAddress(NativeContract.RoleManagement.GetDesignatedByRole(currentSnapshot, Role.StateValidator, currentSnapshot.Height))
};
Interlocked.Exchange(ref addressWhiteList, whiteList)?.Clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this code to RoleManagement contract?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.

@erikzhang erikzhang added this to the NEO 3.0 milestone Dec 28, 2020
@shargon
Copy link
Member Author

shargon commented Jan 6, 2021

Merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants