StorageItem: optimize binary representation #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After neo-project#2351 StorageItem is just a thin wrapper for some byte array in its essence so we can Use the same trick as was used for storage keys in neo-project#1566 and avoid additional wrapping/unwrapping with VarBytes encoding.
shargon
reviewed
Mar 6, 2021
It's always 0.
|
It also technically allows to do item serialization without intermediate |
shargon
approved these changes
Mar 7, 2021
erikzhang
approved these changes
Mar 8, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Apr 20, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Apr 30, 2021
* neo-project/neo#2295 * neo-project/neo#2290 * neo-project/neo#2292 * neo-project/neo#2296 * neo-project/neo#2301 * neo-project/neo#2298 * neo-project/neo#2312 * neo-project/neo#2300 * neo-project/neo#2333 * neo-project/neo#2337 * neo-project/neo#2331 * neo-project/neo#2332 * neo-project/neo#2343 * neo-project/neo#2339 * neo-project/neo#2350 * neo-project/neo#2351 * neo-project/neo#2353 * neo-project/neo#2356 * neo-project/neo#2375 * neo-project/neo#2377 * neo-project/neo#2379 * https://github.com/neo-project/neo/pull/2392/files * neo-project/neo#2400 * audit updates * refactor and bump VM requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2351 StorageItem is just a thin wrapper for some byte array in its
essence so we can Use the same trick as was used for storage keys in #1566 and
avoid additional wrapping/unwrapping with VarBytes encoding.