Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NNS to neo-cli #3032

Merged
merged 29 commits into from
Jan 11, 2024
Merged

Adding NNS to neo-cli #3032

merged 29 commits into from
Jan 11, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Dec 17, 2023

This adds Neo Name Service to the neo-cli.

Allows you do something like this.

> send contract.tips.neo me.neo 100000000

Anywhere that accepts the UInt160 data type. You can use a *.neo domain name.

Screenshot 2023-12-16 213612

image

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Dec 17, 2023

@shargon
Once neo-project/non-native-contracts#15 and neo-project/non-native-contracts#33 is finished. Than NNS contract updated. I will update everything else in neo-cli. For the time being this PR is a good start.

src/Neo.ConsoleService/ConsoleServiceBase.cs Outdated Show resolved Hide resolved
src/Neo.CLI/CLI/MainService.cs Outdated Show resolved Hide resolved
src/Neo.CLI/CLI/MainService.cs Outdated Show resolved Hide resolved
@cschuchardt88 cschuchardt88 marked this pull request as draft December 20, 2023 06:51
@cschuchardt88 cschuchardt88 changed the title NNS to neo-cli Adding NNS to neo-cli Dec 20, 2023
@cschuchardt88 cschuchardt88 marked this pull request as ready for review December 20, 2023 11:50
@cschuchardt88
Copy link
Member Author

@superboyiii @shargon This is ready for review, whenever you have time.

src/Neo.CLI/Settings.cs Outdated Show resolved Hide resolved
src/Neo.CLI/Settings.cs Outdated Show resolved Hide resolved
shargon
shargon previously approved these changes Jan 3, 2024
Jim8y
Jim8y previously approved these changes Jan 9, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jan 9, 2024

@cschuchardt88 need fix error

@cschuchardt88
Copy link
Member Author

#3042 broke it, but ill fix

@shargon shargon merged commit de7fc93 into neo-project:master Jan 11, 2024
2 checks passed
@shargon shargon deleted the add-nns branch January 11, 2024 12:22
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 11, 2024
* master:
  Adding NNS to `neo-cli` (neo-project#3032)

# Conflicts:
#	src/Neo.CLI/Settings.cs
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 12, 2024
* master:
  Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085)
  Adding Devcontainer and link to codespace (neo-project#3075)
  Update & Consolidate nugets (neo-project#3083)
  Adding NNS to `neo-cli` (neo-project#3032)
  Add: add pull request template (neo-project#3081)
  Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077)
  Add: add a new verify result status code (neo-project#3076)
  Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044)
  Avoid IsExternalInit  (neo-project#3079)
  Clean usings (neo-project#3078)
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants