-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding NNS to neo-cli
#3032
Merged
Merged
Adding NNS to neo-cli
#3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shargon |
shargon
reviewed
Dec 19, 2023
Updated code to reflect the changes
@superboyiii @shargon This is ready for review, whenever you have time. |
shargon
reviewed
Dec 27, 2023
shargon
previously approved these changes
Jan 3, 2024
Jim8y
previously approved these changes
Jan 9, 2024
@cschuchardt88 need fix error |
#3042 broke it, but ill fix |
shargon
reviewed
Jan 9, 2024
Two vs one in this discussion
shargon
approved these changes
Jan 11, 2024
Jim8y
approved these changes
Jan 11, 2024
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Jan 11, 2024
* master: Adding NNS to `neo-cli` (neo-project#3032) # Conflicts: # src/Neo.CLI/Settings.cs
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Jan 12, 2024
* master: Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085) Adding Devcontainer and link to codespace (neo-project#3075) Update & Consolidate nugets (neo-project#3083) Adding NNS to `neo-cli` (neo-project#3032) Add: add pull request template (neo-project#3081) Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077) Add: add a new verify result status code (neo-project#3076) Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044) Avoid IsExternalInit (neo-project#3079) Clean usings (neo-project#3078) Fixed asp.net core project (neo-project#3067) Updated BLS12_381 (neo-project#3074) avoid nonsense exception messages. (neo-project#3063) Removed `MyGet` (neo-project#3071) Updated unit-test (neo-project#3073) add hash verification for OnImport (neo-project#3070) Make public ReadUserInput (neo-project#3068) Removed asp.net core (neo-project#3065) Enforce Line Endings in `.editorconfig` (neo-project#3060) # Conflicts: # src/Neo.CLI/CLI/MainService.cs
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Neo Name Service
to theneo-cli
.Allows you do something like this.
Anywhere that accepts the
UInt160
data type. You can use a*.neo
domain name.